You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "jiaoqingbo (via GitHub)" <gi...@apache.org> on 2023/03/21 08:31:55 UTC
[GitHub] [incubator-celeborn] jiaoqingbo opened a new pull request, #1368: [CELEBORN-453] In the removeExpiredShuffle method, the taskShuffleId should be removed instead of the shuffleId
jiaoqingbo opened a new pull request, #1368:
URL: https://github.com/apache/incubator-celeborn/pull/1368
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
In the removeExpiredShuffle method, the taskShuffleId should be removed instead of the shuffleId
### Why are the changes needed?
In the removeExpiredShuffle method, the taskShuffleId should be removed instead of the shuffleId
### Does this PR introduce _any_ user-facing change?
NO
### How was this patch tested?
UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1368: [CELEBORN-453] [FLINK] In the removeExpiredShuffle method, the taskShuffleId should be removed instead of the shuffleId
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1368:
URL: https://github.com/apache/incubator-celeborn/pull/1368#issuecomment-1477452726
## [Codecov](https://codecov.io/gh/apache/incubator-celeborn/pull/1368?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1368](https://codecov.io/gh/apache/incubator-celeborn/pull/1368?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fc7e927) into [main](https://codecov.io/gh/apache/incubator-celeborn/commit/56d796638f864a4a96913074115def80f7eb3fc9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (56d7966) will **increase** coverage by `0.03%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #1368 +/- ##
============================================
+ Coverage 29.86% 29.88% +0.03%
- Complexity 917 918 +1
============================================
Files 220 220
Lines 18498 18498
Branches 1974 1974
============================================
+ Hits 5523 5527 +4
+ Misses 12585 12582 -3
+ Partials 390 389 -1
```
[see 3 files with indirect coverage changes](https://codecov.io/gh/apache/incubator-celeborn/pull/1368/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] RexXiong merged pull request #1368: [CELEBORN-453] [FLINK] In the removeExpiredShuffle method, the taskShuffleId should be removed instead of the shuffleId
Posted by "RexXiong (via GitHub)" <gi...@apache.org>.
RexXiong merged PR #1368:
URL: https://github.com/apache/incubator-celeborn/pull/1368
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture commented on pull request #1368: [CELEBORN-453] [FLINK] In the removeExpiredShuffle method, the taskShuffleId should be removed instead of the shuffleId
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture commented on PR #1368:
URL: https://github.com/apache/incubator-celeborn/pull/1368#issuecomment-1477445589
ping @RexXiong , please take a review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org