You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yyqdbngt (via GitHub)" <gi...@apache.org> on 2026/09/04 02:08:24 UTC

[PR] fix(i18n): localize consumer reset and import leftovers [rocketmq-dashboard]

yyqdbngt opened a new pull request, #3073:
URL: https://github.com/apache/rocketmq-dashboard/pull/3073

   ### Summary
   Localize the last uncovered copy on the Consumer page (`pages/instance/consumer.tsx`) — 8 literals untouched by the earlier consumer i18n slices (163 candidate literals mined; only these had no i18n commit):
   
   - **Reset-preview flow**: the preview-failure fallback and the offset-reset success toast (parameterized `{group}` / `{topic}` / `{time}`).
   - **Group import flow**: row outcome messages `已创建` / `创建失败` (both fallback sites) and the CSV parse-failure fallback.
   - **Reset modal**: the `请确认以下影响` alert headline and the preview-table empty text.
   
   ### Why
   These messages sat inside flows whose surrounding UI was already localized (reset-preview and group-import), leaving hardcoded Chinese toasts in English mode; the two remaining zh literals on the page are backend enum values (`全量` / `Tag 过滤`) that deliberately map server data and are out of scope.
   
   ### Testing
   - `tsc --noEmit` passes (exit 0).
   - `eslint` clean on changed files (0 errors).
   - Vitest: full `ConsumerPage` suite passes (24/24), including reset preview and import tests.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(i18n): localize consumer reset and import leftovers [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #3073: fix(i18n): localize consumer reset and import leftovers
URL: https://github.com/apache/rocketmq-dashboard/pull/3073


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org