You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/03/18 13:00:42 UTC

[GitHub] [arrow] lidavidm commented on a change in pull request #12661: ARROW-14960: [C++] Add exception to Arrow style guide based on changes in Google style guide that we are not adopting

lidavidm commented on a change in pull request #12661:
URL: https://github.com/apache/arrow/pull/12661#discussion_r829976240



##########
File path: docs/source/developers/cpp/development.rst
##########
@@ -85,6 +85,8 @@ This project follows `Google's C++ Style Guide
   conveniences.  For private headers the rules are relaxed further and structs
   can be used where convenient for types that do not need access control even
   though they may not be simple data containers.
+* We prefer pointers for non-optional output and input/output parameters (the
+  style guide recommends mutable references).

Review comment:
       I think just declaring we always prefer pointers is clearer, yeah.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org