You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by "merlimat (via GitHub)" <gi...@apache.org> on 2023/03/01 01:46:39 UTC
[GitHub] [bookkeeper] merlimat opened a new pull request, #3826: Fixed back API of Crc32cIntChecksum
merlimat opened a new pull request, #3826:
URL: https://github.com/apache/bookkeeper/pull/3826
### Motivation
In #3810 the signature of `Crc32cIntChecksum.resumeChecksum()` was changed to accept `offset` & `len` in the buffer.
Since this method is also used externally (in Pulsar), we should leave also the old method signature to avoid breaking the API when upgrading BK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] Shoothzj merged pull request #3826: Fixed back API of Crc32cIntChecksum
Posted by "Shoothzj (via GitHub)" <gi...@apache.org>.
Shoothzj merged PR #3826:
URL: https://github.com/apache/bookkeeper/pull/3826
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] codecov-commenter commented on pull request #3826: Fixed back API of Crc32cIntChecksum
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #3826:
URL: https://github.com/apache/bookkeeper/pull/3826#issuecomment-1449560060
# [Codecov](https://codecov.io/gh/apache/bookkeeper/pull/3826?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3826](https://codecov.io/gh/apache/bookkeeper/pull/3826?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5e7b8b4) into [master](https://codecov.io/gh/apache/bookkeeper/commit/6d003367280b0a761d02dbfc8c8d6ab8b6637e73?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6d00336) will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #3826 +/- ##
============================================
+ Coverage 68.37% 68.39% +0.01%
- Complexity 6759 6760 +1
============================================
Files 473 473
Lines 40972 40972
Branches 5241 5241
============================================
+ Hits 28015 28021 +6
+ Misses 10699 10698 -1
+ Partials 2258 2253 -5
```
| Flag | Coverage Δ | |
|---|---|---|
| bookie | `39.84% <ø> (+0.02%)` | :arrow_up: |
| client | `44.24% <ø> (+0.06%)` | :arrow_up: |
| remaining | `29.51% <ø> (-0.01%)` | :arrow_down: |
| replication | `41.38% <ø> (-0.06%)` | :arrow_down: |
| tls | `20.98% <ø> (-0.07%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/bookkeeper/pull/3826?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...org/apache/bookkeeper/client/BookieInfoReader.java](https://codecov.io/gh/apache/bookkeeper/pull/3826?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvY2xpZW50L0Jvb2tpZUluZm9SZWFkZXIuamF2YQ==) | `65.40% <0.00%> (-9.73%)` | :arrow_down: |
| [...g/apache/bookkeeper/client/MetadataUpdateLoop.java](https://codecov.io/gh/apache/bookkeeper/pull/3826?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvY2xpZW50L01ldGFkYXRhVXBkYXRlTG9vcC5qYXZh) | `80.00% <0.00%> (-7.15%)` | :arrow_down: |
| [...g/apache/bookkeeper/proto/WriteEntryProcessor.java](https://codecov.io/gh/apache/bookkeeper/pull/3826?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvcHJvdG8vV3JpdGVFbnRyeVByb2Nlc3Nvci5qYXZh) | `76.05% <0.00%> (-5.64%)` | :arrow_down: |
| [.../main/java/org/apache/bookkeeper/util/ZkUtils.java](https://codecov.io/gh/apache/bookkeeper/pull/3826?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvdXRpbC9aa1V0aWxzLmphdmE=) | `77.31% <0.00%> (-5.16%)` | :arrow_down: |
| [.../apache/bookkeeper/proto/ReadEntryProcessorV3.java](https://codecov.io/gh/apache/bookkeeper/pull/3826?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvcHJvdG8vUmVhZEVudHJ5UHJvY2Vzc29yVjMuamF2YQ==) | `62.50% <0.00%> (-2.09%)` | :arrow_down: |
| [...java/org/apache/bookkeeper/client/BKException.java](https://codecov.io/gh/apache/bookkeeper/pull/3826?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvY2xpZW50L0JLRXhjZXB0aW9uLmphdmE=) | `65.44% <0.00%> (-1.48%)` | :arrow_down: |
| [...apache/bookkeeper/meta/MSLedgerManagerFactory.java](https://codecov.io/gh/apache/bookkeeper/pull/3826?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvbWV0YS9NU0xlZGdlck1hbmFnZXJGYWN0b3J5LmphdmE=) | `35.04% <0.00%> (-0.81%)` | :arrow_down: |
| [...r/client/TopologyAwareEnsemblePlacementPolicy.java](https://codecov.io/gh/apache/bookkeeper/pull/3826?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvY2xpZW50L1RvcG9sb2d5QXdhcmVFbnNlbWJsZVBsYWNlbWVudFBvbGljeS5qYXZh) | `77.13% <0.00%> (-0.56%)` | :arrow_down: |
| [...va/org/apache/bookkeeper/bookie/EntryMemTable.java](https://codecov.io/gh/apache/bookkeeper/pull/3826?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvYm9va2llL0VudHJ5TWVtVGFibGUuamF2YQ==) | `84.32% <0.00%> (-0.55%)` | :arrow_down: |
| [...ava/org/apache/bookkeeper/client/PendingAddOp.java](https://codecov.io/gh/apache/bookkeeper/pull/3826?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvY2xpZW50L1BlbmRpbmdBZGRPcC5qYXZh) | `87.86% <0.00%> (-0.49%)` | :arrow_down: |
| ... and [17 more](https://codecov.io/gh/apache/bookkeeper/pull/3826?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org