You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/04/08 11:14:44 UTC

[GitHub] [apisix] Firstsawyou commented on a change in pull request #4004: fix: use route/service name instead of id in prometheus metric

Firstsawyou commented on a change in pull request #4004:
URL: https://github.com/apache/apisix/pull/4004#discussion_r609583741



##########
File path: t/plugin/prometheus2.t
##########
@@ -78,6 +78,7 @@ passed
 [401, 401, 401, 401]
 --- no_error_log
 [error]
+-- LAST

Review comment:
       We should remove `-- LAST`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org