You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/07 07:02:39 UTC

[GitHub] [spark] martin-g commented on a change in pull request #35745: [SPARK-38430][K8S][DOCS] Add `SBT` commands to K8s IT README

martin-g commented on a change in pull request #35745:
URL: https://github.com/apache/spark/pull/35745#discussion_r820424635



##########
File path: resource-managers/kubernetes/integration-tests/README.md
##########
@@ -269,3 +269,28 @@ to the wrapper scripts and using the wrapper scripts will simply set these appro
     <td></td>
   </tr>
 </table>
+
+# Running the Kubernetes Integration Tests with SBT
+
+You can use SBT in the same way to build image and run all K8s integration tests except Minikube-only ones.
+
+    build/sbt -Psparkr -Pkubernetes -Pkubernetes-integration-tests \
+        -Dtest.exclude.tags=minikube \
+        -Dspark.kubernetes.test.deployMode=docker-desktop \
+        -Dspark.kubernetes.test.imageTag=2022-03-06 \
+        'kubernetes-integration-tests/test'
+
+The following is an example to rerun tests with the pre-built image.

Review comment:
       Thanks for adding this documentation!
   
   It is not very clear to me what is the difference between `.../test` and `.../runIts` ?
   Is it that the first one (re-)builds the image and the second would fail if there is no image ? 

##########
File path: resource-managers/kubernetes/integration-tests/README.md
##########
@@ -269,3 +269,28 @@ to the wrapper scripts and using the wrapper scripts will simply set these appro
     <td></td>
   </tr>
 </table>
+
+# Running the Kubernetes Integration Tests with SBT
+
+You can use SBT in the same way to build image and run all K8s integration tests except Minikube-only ones.
+
+    build/sbt -Psparkr -Pkubernetes -Pkubernetes-integration-tests \

Review comment:
       Not directly related to this PR but for `./build/mvn` one has to add a profile for Hadoop 2/3 (e.g. `-Phadoop-3`). Otherwise the build fails due to missing AWS classes.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org