You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@daffodil.apache.org by GitBox <gi...@apache.org> on 2021/11/17 19:59:05 UTC

[GitHub] [daffodil-vscode] Shanedell commented on a change in pull request #51: License for distribution with vsix

Shanedell commented on a change in pull request #51:
URL: https://github.com/apache/daffodil-vscode/pull/51#discussion_r751591257



##########
File path: LICENSE.bin
##########
@@ -0,0 +1,595 @@
+
+                                 Apache License
+                           Version 2.0, January 2004

Review comment:
       @jw3 For packaging different files into the VSIX (extension) file all that would need updated is the `.vscodeignore` file.
   
   So if you don't want the regular `LICENSE` and `NOTICE` to be in the VSIX, remove these lines from `.vscodeignore`
   ```
   !LICENSE
   !NOTICE
   ```
   
   Then if you want the `bin.LICENSE` and `bin.NOTICE` added to the VSIX,  add these lines to `.vscodeignore`
   ```
   !build/bin.LICENSE
   !build/bin.NOTICE
   ```
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org