You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by jpeach <gi...@git.apache.org> on 2016/09/13 17:10:05 UTC
[GitHub] trafficserver pull request #1012: TS-4840 Crash when reattaching to C++ API ...
GitHub user jpeach opened a pull request:
https://github.com/apache/trafficserver/pull/1012
TS-4840 Crash when reattaching to C++ API Stats.
The change in TS-4793 regressed the C++ API Stat object. What happens is that if you restart traffic_server without traffic_manager, the TSStatFindName call finds the metric in the records hash table, but traffic_server has not set up the RSB entry so actually incrementing it crashes.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jpeach/trafficserver fix/4840
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/1012.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1012
----
commit 77180a3a5771dc1d30820692ddd90862671dafb5
Author: James Peach <jp...@apache.org>
Date: 2016-09-13T16:39:20Z
TS-4840: Ensure unallocated stats cannot be reattached.
If traffic_server is restarted, any plugin stats that have been
created are still registered in traffic_manager so we can find them
on startup with TSStatFindName. However, because traffic_server is
a new process, we don't have them allocated in the plugin RSB so
things go awry from there.
The solution is to not allow TSStatFindName to succeed unless there
is a also plugin TSB entry allocated for this stat.
commit ea572e619dbd0fbd034154b94e32269a875a81d2
Author: James Peach <jp...@apache.org>
Date: 2016-09-13T16:42:50Z
TS-4840: Clean up RecRawStats formatting.
commit 917731b8f0950028715c0e790a48edecae7993fe
Author: James Peach <jp...@apache.org>
Date: 2016-09-13T17:07:20Z
TS-4840: Add statistic test plugin.
Add an example plugin to demonstrate the statistics API and update
the developer docs accordingly.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1012: TS-4840: Crash when reattaching to C++ API...
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach closed the pull request at:
https://github.com/apache/trafficserver/pull/1012
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1012: TS-4840: Crash when reattaching to C++ API Stats.
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1012
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/686/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1012: TS-4840: Crash when reattaching to C++ API Stats.
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1012
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/790/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1012: TS-4840: Crash when reattaching to C++ API Stats.
Posted by bryancall <gi...@git.apache.org>.
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1012
\U0001f44d - Looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---