You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/07/10 02:48:07 UTC
[GitHub] [flink] TsReaper commented on a change in pull request #9027:
[FLINK-13161][table-blink-runtime]numBuckets calculate wrong in
BinaryHashBucketArea
TsReaper commented on a change in pull request #9027: [FLINK-13161][table-blink-runtime]numBuckets calculate wrong in BinaryHashBucketArea
URL: https://github.com/apache/flink/pull/9027#discussion_r301866936
##########
File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/hashtable/BinaryHashBucketArea.java
##########
@@ -203,7 +203,7 @@ private void resize(boolean spillingAllowed) throws IOException {
int oldNumBuckets = numBuckets;
MemorySegment[] oldOverflowSegments = overflowSegments;
int newNumSegs = oldBuckets.length * 2;
- int newNumBuckets = MathUtils.roundDownToPowerOf2(newNumSegs << table.bucketsPerSegmentBits);
Review comment:
No need. This will be checked in the `setNewBuckets` method called below (line 238).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services