You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/12/02 21:22:49 UTC

[GitHub] [geode] mkevo commented on a change in pull request #5803: GEODE-8742: fix list gateways command when dispatcher-threads is set …

mkevo commented on a change in pull request #5803:
URL: https://github.com/apache/geode/pull/5803#discussion_r534489795



##########
File path: geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/wancommand/ListGatewaysCommandDUnitTest.java
##########
@@ -452,8 +452,10 @@ public void testListGatewaysReceiversOnlyFalseAndSendersOnlyFalseReturnsSendersA
 
   @Test
   public void testListGatewaysWithOneDispatcherThread() {
-    String command =
-        "create gateway-sender --id=ln_Serial --remote-distributed-system-id=2 --dispatcher-threads=1";
+    String command = CliStrings.CREATE_GATEWAYSENDER + " --" + CliStrings.CREATE_GATEWAYSENDER__ID

Review comment:
       Nice! I take a look on test above, so I do on this way, but this proposal is better.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org