You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2019/07/10 21:50:05 UTC
[kudu-CR](branch-1.10.x) Fix KuduScanTokenBuilder::SetDiffScan docs
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13839
Change subject: Fix KuduScanTokenBuilder::SetDiffScan docs
......................................................................
Fix KuduScanTokenBuilder::SetDiffScan docs
It looks like Doxygen can’t use `@copydoc` when
the doc being copied is in a `@cond PRIVATE_API`.
Change-Id: I448c00b78f9d14685e87d154e1bbee0eaa8e8e24
Reviewed-on: http://gerrit.cloudera.org:8080/13837
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
(cherry picked from commit 0b4948ea3beac43a0dcd2ae2933440d089e337fd)
---
M src/kudu/client/client.h
1 file changed, 18 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/39/13839/1
--
To view, visit http://gerrit.cloudera.org:8080/13839
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.10.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I448c00b78f9d14685e87d154e1bbee0eaa8e8e24
Gerrit-Change-Number: 13839
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR](branch-1.10.x) Fix KuduScanTokenBuilder::SetDiffScan docs
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13839 )
Change subject: Fix KuduScanTokenBuilder::SetDiffScan docs
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13839
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.10.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I448c00b78f9d14685e87d154e1bbee0eaa8e8e24
Gerrit-Change-Number: 13839
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 11 Jul 2019 05:29:06 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.10.x) Fix KuduScanTokenBuilder::SetDiffScan docs
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13839 )
Change subject: Fix KuduScanTokenBuilder::SetDiffScan docs
......................................................................
Fix KuduScanTokenBuilder::SetDiffScan docs
It looks like Doxygen can’t use `@copydoc` when
the doc being copied is in a `@cond PRIVATE_API`.
Change-Id: I448c00b78f9d14685e87d154e1bbee0eaa8e8e24
Reviewed-on: http://gerrit.cloudera.org:8080/13837
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
(cherry picked from commit 0b4948ea3beac43a0dcd2ae2933440d089e337fd)
Reviewed-on: http://gerrit.cloudera.org:8080/13839
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M src/kudu/client/client.h
1 file changed, 18 insertions(+), 1 deletion(-)
Approvals:
Kudu Jenkins: Verified
Andrew Wong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/13839
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.10.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I448c00b78f9d14685e87d154e1bbee0eaa8e8e24
Gerrit-Change-Number: 13839
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)