You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "gopidesupavan (via GitHub)" <gi...@apache.org> on 2025/04/07 23:24:42 UTC
[PR] Move secrets_masker patch to conftest and use as fixture [airflow]
gopidesupavan opened a new pull request, #48901:
URL: https://github.com/apache/airflow/pull/48901
As mentioned @kaxil in slack its causing issue when we run. failing to load secrets_masker.
`pytest task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestWatchedSubprocess::test_reading_from_pipes`
```
___________________________________________________________________________________ TestWatchedSubprocess.test_reading_from_pipes ____________________________________________________________________________________
task-sdk/tests/task_sdk/execution_time/test_supervisor.py:165: in test_reading_from_pipes
rc = proc.wait()
task-sdk/src/airflow/sdk/execution_time/supervisor.py:761: in wait
self._monitor_subprocess()
task-sdk/src/airflow/sdk/execution_time/supervisor.py:819: in _monitor_subprocess
alive = self._service_subprocess(max_wait_time=max_wait_time) is None
task-sdk/src/airflow/sdk/execution_time/supervisor.py:653: in _service_subprocess
need_more = socket_handler(key.fileobj)
task-sdk/src/airflow/sdk/execution_time/supervisor.py:1066: in cb
gen.send(line)
task-sdk/src/airflow/sdk/execution_time/supervisor.py:1126: in forward_to_log
log.log(level, msg, chan=chan)
/usr/local/lib/python3.10/site-packages/structlog/_native.py:179: in log
return self._proxy_to_logger(name, event, **kw)
/usr/local/lib/python3.10/site-packages/structlog/_base.py:222: in _proxy_to_logger
args, kw = self._process_event(method_name, event, event_kw)
/usr/local/lib/python3.10/site-packages/structlog/_base.py:173: in _process_event
event_dict = proc(self._logger, method_name, event_dict)
task-sdk/src/airflow/sdk/log.py:109: in mask_logs
event_dict = redact(event_dict) # type: ignore[assignment]
task-sdk/src/airflow/sdk/execution_time/secrets_masker.py:117: in redact
return _secrets_masker().redact(value, name, max_depth)
task-sdk/src/airflow/sdk/execution_time/secrets_masker.py:125: in _secrets_masker
raise RuntimeError(
E RuntimeError: Logging Configuration Error! No SecretsMasker found! If you have custom logging, please make sure you configure it taking airflow configuration as a base as explained at https://airflow.apache.org/docs/apache-airflow/stable/logging-monitoring/logging-tasks.html#advanced-configuration
```
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move secrets_masker patch to conftest and use as fixture [airflow]
Posted by "gopidesupavan (via GitHub)" <gi...@apache.org>.
gopidesupavan commented on PR #48901:
URL: https://github.com/apache/airflow/pull/48901#issuecomment-2785472668
> pytest task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestWatchedSubprocess::test_reading_from_pipes
Ah it should work, as its require in may tests, better to set fixture to autouse.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move secrets_masker patch to conftest and use as fixture [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on PR #48901:
URL: https://github.com/apache/airflow/pull/48901#issuecomment-2785553914
> > pytest task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestWatchedSubprocess::test_reading_from_pipes
>
> Ah it should work, as its require in may tests, better to set fixture to autouse.
Yeah, I have unblocked myself by doing this:
https://github.com/astronomer/airflow/blob/2e2db3dc1838cfb27aa7a8a8c996c2661d8c75f7/task-sdk/tests/conftest.py#L129-L133
in https://github.com/apache/airflow/pull/48896/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move secrets_masker patch to conftest and use as fixture [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on PR #48901:
URL: https://github.com/apache/airflow/pull/48901#issuecomment-2785937628
I don;t think we need it after the change in https://github.com/astronomer/airflow/blob/2e2db3dc1838cfb27aa7a8a8c996c2661d8c75f7/task-sdk/tests/conftest.py#L129-L133
Closing it for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move secrets_masker patch to conftest and use as fixture [airflow]
Posted by "gopidesupavan (via GitHub)" <gi...@apache.org>.
gopidesupavan commented on PR #48901:
URL: https://github.com/apache/airflow/pull/48901#issuecomment-2784850615
<img width="1712" alt="image" src="https://github.com/user-attachments/assets/61793175-7673-4bcc-9e5d-ca8967f3dd74" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move secrets_masker patch to conftest and use as fixture [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #48901:
URL: https://github.com/apache/airflow/pull/48901#discussion_r2032857586
##########
task-sdk/tests/task_sdk/definitions/test_secrets_masker.py:
##########
@@ -432,14 +432,10 @@ def lineno():
class TestRedactedIO:
- @pytest.fixture(scope="class", autouse=True)
- def reset_secrets_masker(self):
- self.secrets_masker = SecretsMasker()
- with patch(
- "airflow.sdk.execution_time.secrets_masker._secrets_masker", return_value=self.secrets_masker
- ):
- mask_secret(p)
- yield
+ @pytest.fixture(autouse=True)
+ def reset_secrets_masker(self, set_secrets_masker):
+ mask_secret(p)
+ yield
Review Comment:
```suggestion
return
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move secrets_masker patch to conftest and use as fixture [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil closed pull request #48901: Move secrets_masker patch to conftest and use as fixture
URL: https://github.com/apache/airflow/pull/48901
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org