You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@click.apache.org by "Finn Bock (JIRA)" <ji...@apache.org> on 2009/07/31 12:48:14 UTC

[jira] Created: (CLK-574) DateField .help property is rendered twice

DateField .help property is rendered twice
------------------------------------------

                 Key: CLK-574
                 URL: https://issues.apache.org/jira/browse/CLK-574
             Project: Click
          Issue Type: Bug
          Components: extras
    Affects Versions: 2.1.0 RC1
            Reporter: Finn Bock


If the fieldname.help property is defined in the page property file, the help text for the DateField is rendered twice, first after the input field, then after the calendar icon:

<td class="fields" align="left"><label for="date_field">Enter the date</label>&#160;</td>
<td align="left"><input type="text" name="date" id="date_field" value="" size="20" title="The title"/>Help Me!<img align="top" style="cursor:hand" src="/click/calendar/calendar.gif" id="date_field-button"  alt="Calendar" title="Calendar"/>Help Me!</td>

While DateField tries to null out the help field in its render(buffer) method, the getHelp() method in Field will still return the help text from the property file.



TestPage.java:

public class TestPage extends Page {
    @Bindable
    public Form form = new Form();
    public TestPage() {
        form.add(new DateField("date"));
    }
}

TestPage.properties:

date.help=Help Me!
date.title=The title
date.label=Enter the date

test.htm:

<html>
<head>
  <title>Test</title>
</head>
<body>
$form
</html>
</html>



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (CLK-574) DateField .help property is rendered twice

Posted by "Bob Schellink (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CLK-574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bob Schellink resolved CLK-574.
-------------------------------

       Resolution: Fixed
    Fix Version/s: 2.1.0
         Assignee: Bob Schellink

Hi Finn, thanks for raising this issue. Fix checked into trunk.

> DateField .help property is rendered twice
> ------------------------------------------
>
>                 Key: CLK-574
>                 URL: https://issues.apache.org/jira/browse/CLK-574
>             Project: Click
>          Issue Type: Bug
>          Components: extras
>    Affects Versions: 2.1.0 RC1
>            Reporter: Finn Bock
>            Assignee: Bob Schellink
>             Fix For: 2.1.0
>
>
> If the fieldname.help property is defined in the page property file, the help text for the DateField is rendered twice, first after the input field, then after the calendar icon:
> <td class="fields" align="left"><label for="date_field">Enter the date</label>&#160;</td>
> <td align="left"><input type="text" name="date" id="date_field" value="" size="20" title="The title"/>Help Me!<img align="top" style="cursor:hand" src="/click/calendar/calendar.gif" id="date_field-button"  alt="Calendar" title="Calendar"/>Help Me!</td>
> While DateField tries to null out the help field in its render(buffer) method, the getHelp() method in Field will still return the help text from the property file.
> TestPage.java:
> public class TestPage extends Page {
>     @Bindable
>     public Form form = new Form();
>     public TestPage() {
>         form.add(new DateField("date"));
>     }
> }
> TestPage.properties:
> date.help=Help Me!
> date.title=The title
> date.label=Enter the date
> test.htm:
> <html>
> <head>
>   <title>Test</title>
> </head>
> <body>
> $form
> </html>
> </html>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.