DO NOT REPLY [Bug 50134] TransactionController : Reports bad response time when it contains other TransactionControllers

[bu...@apache.org]

https://issues.apache.org/bugzilla/show_bug.cgi?id=50134

--- Comment #12 from Philippe Mouawad <p....@ubik-ingenierie.com> 2010-11-01 06:11:47 EDT ---
Created an attachment (id=26245)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26245)
Patch to issue

Hello,
I analyzed a bit more what was happening.
I think I understood where the issue comes from.

As the plan is built, here is how sampleOccured in TransactionController is
called:
SampleOccured :s4-1-s1 in :s4-chapeau
SampleOccured :s4-1-s1 in :scenario5
SampleOccured :s4-1-s2 in :s4-chapeau
SampleOccured :s4-1-s2 in :scenario5
SampleOccured :s4-chapeau in :scenario5

This is because scenario5 and s4-chapeau are both registered as listeners for
each sample, this end up in the upper most parent recording twice things and
mixing up pause time.


In my analysis there are 2 types of SampleEvent:
- One that is initiated by a real Sample
- One that is initiated "artificially" by TransactionController#next2, this one
should not be used in computations


So my idea was to distinguish them by an additional attribute called
isTransactionSampleEvent.
I use this attribute setting it to true in next2() to build the SampleEvent
and use it in sampleOccured() to use it in computation or not.


I tested with the existing test plan and the one that is a bit more complicated
and it works.
But I think you have the big picture to validate this modification.

By the way you will notice some changes in SampleEvent because I made some
refactoring in the constructor to make them use each others instead of
copy/paste.


Thank you for your time and great product and hope you will have some time to
take this patch into account.

Regards
Philippe M.
http://www.ubik-ingenierie.com

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org