You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by "myjimmy (via GitHub)" <gi...@apache.org> on 2024/01/10 10:49:51 UTC
[PR] GUACAMOLE-1892: Fix the build issues related to librt for Ubuntu 22.04. [guacamole-server]
myjimmy opened a new pull request, #476:
URL: https://github.com/apache/guacamole-server/pull/476
I've fixed the build issues related to librt for Ubuntu 22.04.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-1892: Fix the build issues related to librt for Ubuntu 22.04. [guacamole-server]
Posted by "mike-jumper (via GitHub)" <gi...@apache.org>.
mike-jumper commented on code in PR #476:
URL: https://github.com/apache/guacamole-server/pull/476#discussion_r1447790467
##########
src/libguac/Makefile.am:
##########
@@ -171,5 +171,6 @@ libguac_la_LDFLAGS = \
@UUID_LIBS@ \
@VORBIS_LIBS@ \
@WEBP_LIBS@ \
- @WINSOCK_LIBS@
+ @WINSOCK_LIBS@ \
+ @RT_LIBS@
Review Comment:
Please maintain alphabetical ordering.
##########
configure.ac:
##########
@@ -68,6 +68,10 @@ AC_CHECK_LIB([pthread], [pthread_create], [PTHREAD_LIBS=-lpthread
AC_DEFINE([HAVE_LIBPTHREAD],,
[Whether libpthread was found])])
+# librt
+AC_CHECK_LIB([rt], [timer_create], [RT_LIBS=-lrt],
+ AC_MSG_ERROR("librt is required for performing timer-related operations"))
Review Comment:
It's not _universally_ required. This check should only be fatal where there is no `timer_create()` without linking in librt. If the test determines that `timer_create()` does not require linking with librt, this check should pass and `RT_LIBS` should be empty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-1892: Fix the build issues related to librt for Ubuntu 22.04. [guacamole-server]
Posted by "mike-jumper (via GitHub)" <gi...@apache.org>.
mike-jumper commented on code in PR #476:
URL: https://github.com/apache/guacamole-server/pull/476#discussion_r1447937025
##########
configure.ac:
##########
@@ -68,6 +68,11 @@ AC_CHECK_LIB([pthread], [pthread_create], [PTHREAD_LIBS=-lpthread
AC_DEFINE([HAVE_LIBPTHREAD],,
[Whether libpthread was found])])
+# librt
+RT_LIBS=
+AC_CHECK_LIB([rt], [timer_create], [RT_LIBS=-lrt],
+ AC_MSG_ERROR("librt is required for performing timer-related operations"))
Review Comment:
Please see https://github.com/apache/guacamole-server/pull/476#discussion_r1447776140:
> It's not _universally_ required. This check should only be fatal where there is no `timer_create()` without linking in librt. If the test determines that `timer_create()` does not require linking with librt, this check should pass and `RT_LIBS` should be empty.
As written, this test will fail the build if librt is absent, even if the platform in question doesn't require librt for `timer_create()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-1892: Fix the build issues related to librt for Ubuntu 22.04. [guacamole-server]
Posted by "myjimmy (via GitHub)" <gi...@apache.org>.
myjimmy commented on code in PR #476:
URL: https://github.com/apache/guacamole-server/pull/476#discussion_r1447983612
##########
configure.ac:
##########
@@ -68,6 +68,11 @@ AC_CHECK_LIB([pthread], [pthread_create], [PTHREAD_LIBS=-lpthread
AC_DEFINE([HAVE_LIBPTHREAD],,
[Whether libpthread was found])])
+# librt
+RT_LIBS=
+AC_CHECK_LIB([rt], [timer_create], [RT_LIBS=-lrt],
+ AC_MSG_ERROR("librt is required for performing timer-related operations"))
Review Comment:
@mike-jumper I've fixed the above code specified by you.
##########
configure.ac:
##########
@@ -68,6 +68,11 @@ AC_CHECK_LIB([pthread], [pthread_create], [PTHREAD_LIBS=-lpthread
AC_DEFINE([HAVE_LIBPTHREAD],,
[Whether libpthread was found])])
+# librt
+RT_LIBS=
+AC_CHECK_LIB([rt], [timer_create], [RT_LIBS=-lrt],
+ AC_MSG_ERROR("librt is required for performing timer-related operations"))
Review Comment:
@mike-jumper I've fixed the above code specified by you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-1892: Fix the build issues related to librt for Ubuntu 22.04. [guacamole-server]
Posted by "mike-jumper (via GitHub)" <gi...@apache.org>.
mike-jumper merged PR #476:
URL: https://github.com/apache/guacamole-server/pull/476
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-1892: Fix the build issues related to librt for Ubuntu 22.04. [guacamole-server]
Posted by "myjimmy (via GitHub)" <gi...@apache.org>.
myjimmy commented on code in PR #476:
URL: https://github.com/apache/guacamole-server/pull/476#discussion_r1447983612
##########
configure.ac:
##########
@@ -68,6 +68,11 @@ AC_CHECK_LIB([pthread], [pthread_create], [PTHREAD_LIBS=-lpthread
AC_DEFINE([HAVE_LIBPTHREAD],,
[Whether libpthread was found])])
+# librt
+RT_LIBS=
+AC_CHECK_LIB([rt], [timer_create], [RT_LIBS=-lrt],
+ AC_MSG_ERROR("librt is required for performing timer-related operations"))
Review Comment:
@mike-jumper I've fixed the above code specified by you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-1892: Fix the build issues related to librt for Ubuntu 22.04. [guacamole-server]
Posted by "myjimmy (via GitHub)" <gi...@apache.org>.
myjimmy commented on code in PR #476:
URL: https://github.com/apache/guacamole-server/pull/476#discussion_r1447916233
##########
src/libguac/Makefile.am:
##########
@@ -171,5 +171,6 @@ libguac_la_LDFLAGS = \
@UUID_LIBS@ \
@VORBIS_LIBS@ \
@WEBP_LIBS@ \
- @WINSOCK_LIBS@
+ @WINSOCK_LIBS@ \
+ @RT_LIBS@
Review Comment:
OK, I've changed code according to your opinion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org