You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by "Sylvie-Wxr (via GitHub)" <gi...@apache.org> on 2024/03/05 07:25:10 UTC

[PR] Default Time Range for Querying Data to Last 15 Minutes. [skywalking-banyandb]

Sylvie-Wxr opened a new pull request, #397:
URL: https://github.com/apache/skywalking-banyandb/pull/397

   ### <Feature description>
   - [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
   - [ ] Update the documentation to include this new feature.
   - [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
   - [x] If it's UI related, attach the screenshots below.
   - [x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Fixes apache/skywalking#11973.
   - [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking-banyandb/blob/main/CHANGES.md).
   
   ### Feature Description: 
   - When selecting a stream or measure, the time range with be auto set to last 15 minutes.  
   ![image](https://github.com/apache/skywalking-banyandb/assets/129717259/91954195-9644-4a41-8748-04027f184b13)
   
   - After the user click search, the time range will be reset to last 15 minutes, unless the user has manually selected other time intervals (last week, last month, last 3 months). 
   ![image](https://github.com/apache/skywalking-banyandb/assets/129717259/2a594c6b-1585-47a3-b021-0cf7b30ee988)
   
   ### Video Demo 
   
   https://github.com/apache/skywalking-banyandb/assets/129717259/5ee28566-e296-4f05-890b-be3fdb6a7057
   
   ### Implementation Explannation:
   1. Added ` :key="$route.path"` in `RouterView` to trigger an router-view reinitialization everytime an read editor is selected.  
   2. Fix code bug in `initCode` function where the startTime is set wrongly to -15 microseconds. 
   3. Remove redundant logic `isDatePicker`. This boolean flag is no longer necessary after the default 15 mins logic has been implemented correctly. 
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Default Time Range for Querying Data to Last 15 Minutes. [skywalking-banyandb]

Posted by "hanahmily (via GitHub)" <gi...@apache.org>.

hanahmily commented on code in PR #397:
URL: https://github.com/apache/skywalking-banyandb/pull/397#discussion_r1513851766


##########
ui/src/components/Read/index.vue:
##########
@@ -347,27 +344,25 @@ function handleCodeData() {
     getTableData()
 }
 function autoRefreshTimeRange() {
-    if (isDatePicker.value) {
-        let json = yamlToJson(data.code)
-        const begin = new Date()
-        const end = new Date()
-        const oldBeginDate = new Date(json.data.timeRange.begin)
-        const oldEndDate = new Date(json.data.timeRange.end)
-        const interval = oldEndDate.getTime() - oldBeginDate.getTime()
+    let json = yamlToJson(data.code)
+    const begin = new Date()
+    const end = new Date()
+    const oldBeginDate = new Date(json.data.timeRange.begin)
+    const oldEndDate = new Date(json.data.timeRange.end)
+    const interval = oldEndDate.getTime() - oldBeginDate.getTime()
         
-        if (interval === last15Minutes.value) {
-            begin.setTime(begin.getTime() - last15Minutes.value)
-        } else if (interval === lastWeek.value) {
-            begin.setTime(begin.getTime() - lastWeek.value)
-        } else if (interval === lastMonth.value) {
-            begin.setTime(begin.getTime() - lastMonth.value)
-        } else if (interval === last3Months.value) {
-            begin.setTime(begin.getTime() - last3Months.value)
-        }
-        json.data.timeRange.begin = begin.toISOString()
-        json.data.timeRange.end = end.toISOString()
-        data.code = jsonToYaml(json.data).data
+    if (interval === last15Minutes) {
+        begin.setTime(begin.getTime() - last15Minutes)
+    } else if (interval === lastWeek) {
+        begin.setTime(begin.getTime() - lastWeek)
+    } else if (interval === lastMonth) {
+        begin.setTime(begin.getTime() - lastMonth)
+    } else if (interval === last3Months) {
+        begin.setTime(begin.getTime() - last3Months)

Review Comment:
   There is a bug here
   
   The "last xx" dynamic time range type cannot be determined by the interval. If a user selects a fixed time range such as "last 15 minutes", the component will not update the time range upon clicking the search button.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org