[GitHub] [arrow] kou commented on a diff in pull request #36114: GH-36109: [MATLAB] Store a nullptr as the validity bitmap if all array elements are valid

["kou (via GitHub)" <gi...@apache.org>]

kou commented on code in PR #36114:
URL: https://github.com/apache/arrow/pull/36114#discussion_r1237938377


##########
matlab/src/cpp/arrow/matlab/array/proxy/numeric_array.h:
##########
@@ -85,12 +89,12 @@ class NumericArray : public arrow::matlab::array::proxy::Array {
                 // Do not make a copy when creating arrow::Buffer
                 auto data_buffer = std::make_shared<arrow::Buffer>(reinterpret_cast<const uint8_t*>(dt),
                                                               sizeof(CType) * numeric_mda.getNumberOfElements());
-
                 // Pack the validity bitmap values.
-                auto maybe_buffer = arrow::matlab::bit::bitPackMatlabLogicalArray(valid_mda);
+
+                auto maybe_buffer = bit::packValid(valid_mda);
                 MATLAB_ERROR_IF_NOT_OK(maybe_buffer.status(), error::BITPACK_VALIDITY_BITMAP_ERROR_ID);
                 auto packed_validity_bitmap = *maybe_buffer;
-
+       

Review Comment:
   ```suggestion
   
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org