[GitHub] [skywalking] BFergerson edited a comment on pull request #5085: Include request method type in rest mapping annotations

[GitBox <gi...@apache.org>]

BFergerson edited a comment on pull request #5085:
URL: https://github.com/apache/skywalking/pull/5085#issuecomment-657090344


   @wu-sheng, what do you think about using `{GET}` in the endpoint names? I've noticed that makes some endpoint names like `{GET}/users/{id}`. It seems a bit odd like it indicates the `{GET}` is a dynamic property. I was thinking of maybe just changing it to `[GET]` so it would be `[GET]/users/{id}`.
   
   What do you think? I noticed you have an issue about parsing URLs at (https://github.com/apache/skywalking/issues/329). Maybe you have in mind another solution? Like ignoring the endpoint name whenever the span's `Tags.URL` and `Tags.HTTP.METHOD` are set and just doing that combination on the backend? If it was done that way there would be automatic support for any plugin which has REST endpoints, etc.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org