[GitHub] [flink-kubernetes-operator] SteNicholas commented on a change in pull request #141: [FLINK-26894] Support custom validator implementations

[GitBox <gi...@apache.org>]

SteNicholas commented on a change in pull request #141:
URL: https://github.com/apache/flink-kubernetes-operator/pull/141#discussion_r840329568



##########
File path: flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/OperatorConfigOptions.java
##########
@@ -61,12 +62,18 @@
                     .durationType()
                     .defaultValue(Duration.ofSeconds(10))
                     .withDescription(
-                            "The interval before a savepoint trigger attempt is marked as unsuccessful");
+                            "The interval before a savepoint trigger attempt is marked as unsuccessful.");
 
     public static final ConfigOption<Duration> OPERATOR_OBSERVER_FLINK_CLIENT_TIMEOUT =
             ConfigOptions.key("operator.observer.flink.client.timeout")
                     .durationType()
                     .defaultValue(Duration.ofSeconds(10))
                     .withDescription(
                             "The timeout for the observer to wait the flink rest client to return.");
+
+    public static final ConfigOption<String> OPERATOR_DEPLOYMENT_VALIDATOR_TYPE =
+            ConfigOptions.key("operator.deployment.validator.type")

Review comment:
       > support
   
   At present, the implementation has considered the comma separated list and get corresponding validator by the lower case values of the custom validators.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org