[jira] [Commented] (AMQ-3687) HttpSpringEmbeddedTunnelServlet, HttpEmbeddedTunnelServlet, and HttpTunnelServlet are doomed and non-fuctional

["Timothy Bish (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMQ-3687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236036#comment-13236036 ] 

Timothy Bish commented on AMQ-3687:
-----------------------------------

We welcome contributions, feel free to attach some patches with fixes and accompanying unit tests.  
                
> HttpSpringEmbeddedTunnelServlet, HttpEmbeddedTunnelServlet, and HttpTunnelServlet are doomed and non-fuctional
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: AMQ-3687
>                 URL: https://issues.apache.org/jira/browse/AMQ-3687
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: Transport
>    Affects Versions: 5.5.0, 5.5.1
>         Environment: Ubuntu 11.10 (oneiric)
>            Reporter: Thomas Pasch
>              Labels: http-tunneling, servlet, spring
>         Attachments: NuclosJMSBrokerTunnelServlet.java
>
>
> HttpSpringEmbeddedTunnelServlet, HttpEmbeddedTunnelServlet, and HttpTunnelServlet are doomed. This is due to the following:
> 1. Fields listener, transportFactory, transportOptions, and wireFormat are private in HttpTunnelServlet and could not be set up in the hierarchy. They should be protected.
> 2. The classes get some configuration by the servlet context. But
>    a) HttpEmbeddedTunnelService sets 'transportChannelListener' but HttpTunnelServlet reads 'acceptListener' for an instance of 
>       TransportAcceptListener.
>    b) The code 'TransportAcceptListener listener = transportConnector.getAcceptListener()' in HttpEmbeddedTunnelService can't get an
>       instance of TransportAcceptListener because it must be set before. Instead a method for getting a working TransportAcceptListener
>       missing.
>    c) A HttpTransportFactory is required as servlet context attribute 'transportFactory'. There should be a method to construct one.
> 3. HttpSpringEmbeddedTunnelServlet is very strange. I would rather expect it to get the required ActiveMQ from a existing Spring Bean Context. 
> Please find enclosed a Subclass of HttpSpringEmbeddedTunnelServlet that we use that has some HACKS to avoid the defects of the current servlet class hierarchy.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira