You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Andrii Babiichuk <ab...@hortonworks.com> on 2017/10/04 11:10:19 UTC

Review Request 62766: Log Search UI: add event bars for Components list item

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62766/
-----------------------------------------------------------

Review request for Ambari and Oleg Nechiporenko.


Bugs: AMBARI-22128
    https://issues.apache.org/jira/browse/AMBARI-22128


Repository: ambari


Description
-------

Every item of Components filter control should include the bar which reflects the ratio between events of different types for the corresponding component. Should be similar to Hosts filter.


Diffs
-----

  ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.html fc3dac8 
  ambari-logsearch/ambari-logsearch-web/src/app/models/node.model.ts 2891d142 
  ambari-logsearch/ambari-logsearch-web/src/app/models/store.model.ts a6a084f 
  ambari-logsearch/ambari-logsearch-web/src/app/services/component-generator.service.ts c49f40f 
  ambari-logsearch/ambari-logsearch-web/src/app/services/filtering.service.spec.ts e3f731e 
  ambari-logsearch/ambari-logsearch-web/src/app/services/filtering.service.ts 0fff75d 
  ambari-logsearch/ambari-logsearch-web/src/app/services/http-client.service.ts 44a5f6a 


Diff: https://reviews.apache.org/r/62766/diff/1/


Testing
-------

Executed 91 of 91 SUCCESS (2.144 secs / 2.103 secs)


Thanks,

Andrii Babiichuk


Re: Review Request 62766: Log Search UI: add event bars for Components list item

Posted by Oleg Nechiporenko <on...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62766/#review187082
-----------------------------------------------------------


Ship it!




Ship It!

- Oleg Nechiporenko


On Окт. 4, 2017, 11:10 д.п., Andrii Babiichuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62766/
> -----------------------------------------------------------
> 
> (Updated Окт. 4, 2017, 11:10 д.п.)
> 
> 
> Review request for Ambari and Oleg Nechiporenko.
> 
> 
> Bugs: AMBARI-22128
>     https://issues.apache.org/jira/browse/AMBARI-22128
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Every item of Components filter control should include the bar which reflects the ratio between events of different types for the corresponding component. Should be similar to Hosts filter.
> 
> 
> Diffs
> -----
> 
>   ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.html fc3dac8 
>   ambari-logsearch/ambari-logsearch-web/src/app/models/node.model.ts 2891d142 
>   ambari-logsearch/ambari-logsearch-web/src/app/models/store.model.ts a6a084f 
>   ambari-logsearch/ambari-logsearch-web/src/app/services/component-generator.service.ts c49f40f 
>   ambari-logsearch/ambari-logsearch-web/src/app/services/filtering.service.spec.ts e3f731e 
>   ambari-logsearch/ambari-logsearch-web/src/app/services/filtering.service.ts 0fff75d 
>   ambari-logsearch/ambari-logsearch-web/src/app/services/http-client.service.ts 44a5f6a 
> 
> 
> Diff: https://reviews.apache.org/r/62766/diff/1/
> 
> 
> Testing
> -------
> 
> Executed 91 of 91 SUCCESS (2.144 secs / 2.103 secs)
> 
> 
> Thanks,
> 
> Andrii Babiichuk
> 
>