You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/12/02 14:28:02 UTC
[GitHub] [yunikorn-k8shim] pbacsko opened a new pull request, #496: [YUNIKORN-1433] Data race in TestRejectApplications (Application.postAppAccepted vs Application.addTask)
pbacsko opened a new pull request, #496:
URL: https://github.com/apache/yunikorn-k8shim/pull/496
### What is this PR for?
A data race was detected in `TestRejectApplications()`.
Conflicting calls are `Application.postAppAccepted()` and `Application.postAppAccepted()`).
### What type of PR is it?
* [x] - Bug Fix
* [ ] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1433
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] craigcondit closed pull request #496: [YUNIKORN-1433] Data race in TestRejectApplications (Application.postAppAccepted vs Application.addTask)
Posted by GitBox <gi...@apache.org>.
craigcondit closed pull request #496: [YUNIKORN-1433] Data race in TestRejectApplications (Application.postAppAccepted vs Application.addTask)
URL: https://github.com/apache/yunikorn-k8shim/pull/496
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] codecov[bot] commented on pull request #496: [YUNIKORN-1433] Data race in TestRejectApplications (Application.postAppAccepted vs Application.addTask)
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #496:
URL: https://github.com/apache/yunikorn-k8shim/pull/496#issuecomment-1335339087
# [Codecov](https://codecov.io/gh/apache/yunikorn-k8shim/pull/496?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#496](https://codecov.io/gh/apache/yunikorn-k8shim/pull/496?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ed6c945) into [master](https://codecov.io/gh/apache/yunikorn-k8shim/commit/fb44ccd0d38c70ad179b76ca6a808c8a5627b50a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fb44ccd) will **not change** coverage.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #496 +/- ##
=======================================
Coverage 67.52% 67.52%
=======================================
Files 43 43
Lines 7460 7460
=======================================
Hits 5037 5037
Misses 2236 2236
Partials 187 187
```
| [Impacted Files](https://codecov.io/gh/apache/yunikorn-k8shim/pull/496?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/cache/application.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/496/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NhY2hlL2FwcGxpY2F0aW9uLmdv) | `75.36% <100.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org