You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Adam Clarke <cl...@gmail.com> on 2012/06/01 15:56:20 UTC
Review Request: Per latest OAuth2 spec,
handle 400 from refresh_token response
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5330/
-----------------------------------------------------------
Review request for shindig and Stanton Sievers.
Summary
-------
Spec did become for clear about this.
Patch is very simple, just checks for 400 and 401 for legacy purposes.
This addresses bug SHINDIG-1786.
https://issues.apache.org/jira/browse/SHINDIG-1786
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Request.java 1344832
Diff: https://reviews.apache.org/r/5330/diff
Testing
-------
Thanks,
Adam
Re: Review Request: Per latest OAuth2 spec,
handle 400 from refresh_token response
Posted by Stanton Sievers <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5330/#review8288
-----------------------------------------------------------
Ship it!
LGTM
- Stanton
On 2012-06-01 13:56:20, Adam Clarke wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5330/
> -----------------------------------------------------------
>
> (Updated 2012-06-01 13:56:20)
>
>
> Review request for shindig and Stanton Sievers.
>
>
> Summary
> -------
>
> Spec did become for clear about this.
>
> Patch is very simple, just checks for 400 and 401 for legacy purposes.
>
>
> This addresses bug SHINDIG-1786.
> https://issues.apache.org/jira/browse/SHINDIG-1786
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Request.java 1344832
>
> Diff: https://reviews.apache.org/r/5330/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Adam
>
>
Re: Review Request: Per latest OAuth2 spec,
handle 400 from refresh_token response
Posted by Dan Dumont <dd...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5330/#review8543
-----------------------------------------------------------
Ship it!
Ship It!
- Dan Dumont
On June 1, 2012, 1:56 p.m., Adam Clarke wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5330/
> -----------------------------------------------------------
>
> (Updated June 1, 2012, 1:56 p.m.)
>
>
> Review request for shindig and sieverssj_do_not_use.
>
>
> Description
> -------
>
> Spec did become for clear about this.
>
> Patch is very simple, just checks for 400 and 401 for legacy purposes.
>
>
> This addresses bug SHINDIG-1786.
> https://issues.apache.org/jira/browse/SHINDIG-1786
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Request.java 1344832
>
> Diff: https://reviews.apache.org/r/5330/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Adam Clarke
>
>
Re: Review Request: Per latest OAuth2 spec,
handle 400 from refresh_token response
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5330/#review8587
-----------------------------------------------------------
Ship it!
Ship It!
- Ryan Baxter
On June 1, 2012, 1:56 p.m., Adam Clarke wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5330/
> -----------------------------------------------------------
>
> (Updated June 1, 2012, 1:56 p.m.)
>
>
> Review request for shindig and sieverssj_do_not_use.
>
>
> Description
> -------
>
> Spec did become for clear about this.
>
> Patch is very simple, just checks for 400 and 401 for legacy purposes.
>
>
> This addresses bug SHINDIG-1786.
> https://issues.apache.org/jira/browse/SHINDIG-1786
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Request.java 1344832
>
> Diff: https://reviews.apache.org/r/5330/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Adam Clarke
>
>
Re: Review Request: Per latest OAuth2 spec,
handle 400 from refresh_token response
Posted by Stanton Sievers <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5330/#review8590
-----------------------------------------------------------
Ship it!
Committed a while ago and this is in beta2. 18/Jun/12 20:10 Committed revision 1351473.
Adam, please close the review.
- Stanton Sievers
On June 1, 2012, 1:56 p.m., Adam Clarke wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5330/
> -----------------------------------------------------------
>
> (Updated June 1, 2012, 1:56 p.m.)
>
>
> Review request for shindig and sieverssj_do_not_use.
>
>
> Description
> -------
>
> Spec did become for clear about this.
>
> Patch is very simple, just checks for 400 and 401 for legacy purposes.
>
>
> This addresses bug SHINDIG-1786.
> https://issues.apache.org/jira/browse/SHINDIG-1786
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Request.java 1344832
>
> Diff: https://reviews.apache.org/r/5330/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Adam Clarke
>
>