You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "pitrou (via GitHub)" <gi...@apache.org> on 2026/08/31 10:28:01 UTC
[I] [CI][C++] Remove useless test-file-cleanup step [arrow]
pitrou opened a new issue, #51096:
URL: https://github.com/apache/arrow/issues/51096
### Describe the enhancement requested
We have a test file cleanup in `run-test.sh` that calls `find` twice with the same parameters, computes the difference and tries to delete files only in the second result. But nothing happens between the two `find` calls: the results should always be the same (except if there's a race condition).
Since this code isn't doing anything useful, and it doesn't seem to cause any problem, we should just remove it.
https://github.com/apache/arrow/blob/e9ec94b24488330c406c89d70ac9630bd70e1fe4/cpp/build-support/run-test.sh#L195-L222
### Component(s)
C++, Continuous Integration
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [CI][C++] Remove useless test-file-cleanup step [arrow]
Posted by "Diveyam-Mishra (via GitHub)" <gi...@apache.org>.
Diveyam-Mishra commented on issue #51096:
URL: https://github.com/apache/arrow/issues/51096#issuecomment-5484329202
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [CI][C++] Remove useless test-file-cleanup step [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on issue #51096:
URL: https://github.com/apache/arrow/issues/51096#issuecomment-5486578638
Issue resolved by pull request 51110
https://github.com/apache/arrow/pull/51110
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [CI][C++] Remove useless test-file-cleanup step [arrow]
Posted by "Diveyam-Mishra (via GitHub)" <gi...@apache.org>.
Diveyam-Mishra commented on issue #51096:
URL: https://github.com/apache/arrow/issues/51096#issuecomment-5483495645
Seems like a very straight up solution Would like to take this up as my first issue in this repo ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [CI][C++] Remove useless test-file-cleanup step [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on issue #51096:
URL: https://github.com/apache/arrow/issues/51096#issuecomment-5483546685
@Diveyam-Mishra Definitely, but I would like to wait for @kou 's opinion before we do this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [CI][C++] Remove useless test-file-cleanup step [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on issue #51096:
URL: https://github.com/apache/arrow/issues/51096#issuecomment-5477039671
Also, `$TEST_TMPDIR` doesn't seem to be defined...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [CI][C++] Remove useless test-file-cleanup step [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on issue #51096:
URL: https://github.com/apache/arrow/issues/51096#issuecomment-5477036666
@kou @hiroyuki-sato Opinions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [CI][C++] Remove useless test-file-cleanup step [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou closed issue #51096: [CI][C++] Remove useless test-file-cleanup step
URL: https://github.com/apache/arrow/issues/51096
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [CI][C++] Remove useless test-file-cleanup step [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on issue #51096:
URL: https://github.com/apache/arrow/issues/51096#issuecomment-5484302915
Good catch. It seems that this was introduced by GH-29.
We can remove the retry feature entirely from this script because we can use the CTest's retry feature.
@Diveyam-Mishra Could you add "take" only comment here to assign this issue to you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org