[GitHub] [iceberg] stevenzwu commented on a diff in pull request #7337: Core: Support loading multiple metrics reporters

["stevenzwu (via GitHub)" <gi...@apache.org>]

stevenzwu commented on code in PR #7337:
URL: https://github.com/apache/iceberg/pull/7337#discussion_r1166037948


##########
core/src/main/java/org/apache/iceberg/CatalogUtil.java:
##########
@@ -404,12 +410,16 @@ public static void configureHadoopConf(Object maybeConfigurable, Object conf) {
   }
 
   /**
-   * Load a custom {@link MetricsReporter} implementation.
+   * Load a custom {@link MetricsReporter} implementation. This method also supports loading

Review Comment:
   I am wondering if it is cleaner to deprecate this and create a new method and property/config (`METRICS_REPORTER_IMPL_LIST`)?
   ```
   List< MetricsReporter > loadMetricsReporters(...)
   ```



##########
core/src/main/java/org/apache/iceberg/CatalogUtil.java:
##########
@@ -420,6 +430,23 @@ public static MetricsReporter loadMetricsReporter(Map<String, String> properties
       return LoggingMetricsReporter.instance();
     }
 
+    List<String> reporters = COMMA.splitToList(impl);
+    if (reporters.size() == 1) {
+      return loadSingleMetricsReporter(properties, impl);
+    }
+
+    LOG.info("Loading multiple MetricsReporter implementations: {}", impl);

Review Comment:
   let's log it for both cases (single or plural)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org