You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@nemo.apache.org by GitBox <gi...@apache.org> on 2019/02/01 01:12:22 UTC
[GitHub] johnyangk commented on a change in pull request #191: [NEMO-332]
Refactor RunTimePass
johnyangk commented on a change in pull request #191: [NEMO-332] Refactor RunTimePass
URL: https://github.com/apache/incubator-nemo/pull/191#discussion_r252904217
##########
File path: common/src/main/java/org/apache/nemo/common/ir/vertex/transform/StreamTransform.java
##########
@@ -28,14 +28,14 @@
* This transform can be used for merging input data into the {@link OutputCollector}.
* @param <T> input/output type.
*/
-public final class RelayTransform<T> implements Transform<T, T> {
+public final class StreamTransform<T> implements Transform<T, T> {
Review comment:
I think this vertex can be decoupled from `Shuffle`, as it can be inserted regardless of the communication pattern, but I can't think of a better name at the moment. I do think that `Stream` is better than `Relay` in capturing the behavior of "immediately forwarding the input element without modifying it".
How about we revisit this later, after we add more system vertices and streaming functionalities?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services