You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by "jmuehlner (via GitHub)" <gi...@apache.org> on 2024/03/28 21:54:41 UTC
[PR] GUACAMOLE-1931: Add configuration option to allow overwriting typescript files. [guacamole-client]
jmuehlner opened a new pull request, #965:
URL: https://github.com/apache/guacamole-client/pull/965
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-1931: Add configuration option to allow overwriting typescript files. [guacamole-client]
Posted by "necouchman (via GitHub)" <gi...@apache.org>.
necouchman commented on code in PR #965:
URL: https://github.com/apache/guacamole-client/pull/965#discussion_r1543931728
##########
guacamole/src/main/frontend/src/translations/en.json:
##########
@@ -47,6 +47,8 @@
"FIELD_HEADER_PASSWORD_AGAIN" : "Re-enter Password:",
"FIELD_HEADER_RECORDING_WRITE_EXISTING" : "Allow writing to existing recording file:",
+ "FIELD_HEADER_TYPESCRIPT_WRITE_EXISTING" : "Allow writing to existing typescript file:",
Review Comment:
#Nitpick - can you remove the blank line above this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-1931: Add configuration option to allow overwriting typescript files. [guacamole-client]
Posted by "jmuehlner (via GitHub)" <gi...@apache.org>.
jmuehlner commented on code in PR #965:
URL: https://github.com/apache/guacamole-client/pull/965#discussion_r1544669010
##########
guacamole/src/main/frontend/src/translations/en.json:
##########
@@ -47,6 +47,8 @@
"FIELD_HEADER_PASSWORD_AGAIN" : "Re-enter Password:",
"FIELD_HEADER_RECORDING_WRITE_EXISTING" : "Allow writing to existing recording file:",
+ "FIELD_HEADER_TYPESCRIPT_WRITE_EXISTING" : "Allow writing to existing typescript file:",
Review Comment:
Sure; it's done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-1931: Add configuration option to allow overwriting typescript files. [guacamole-client]
Posted by "necouchman (via GitHub)" <gi...@apache.org>.
necouchman merged PR #965:
URL: https://github.com/apache/guacamole-client/pull/965
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org