[GitHub] spark pull request #17402: [SPARK-7200] Check that memory is not leaked in T...

[jsoltren <gi...@git.apache.org>]

Github user jsoltren commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17402#discussion_r116881319
  
    --- Diff: core/src/test/java/org/apache/spark/memory/TaskMemoryManagerSuite.java ---
    @@ -25,27 +26,37 @@
     
     public class TaskMemoryManagerSuite {
     
    +  static TaskMemoryManager manager;
    +
    +  @After
    +  public void after() {
    +    Assert.assertEquals(0, manager.getMemoryConsumptionForThisTask());
    +    Assert.assertEquals(0, manager.cleanUpAllAllocatedMemory());
    +    manager = null;
    +  }
    +
       @Test
       public void leakedPageMemoryIsDetected() {
    -    final TaskMemoryManager manager = new TaskMemoryManager(
    +    manager = new TaskMemoryManager(
           new StaticMemoryManager(
             new SparkConf().set("spark.memory.offHeap.enabled", "false"),
             Long.MAX_VALUE,
             Long.MAX_VALUE,
             1),
           0);
         final MemoryConsumer c = new TestMemoryConsumer(manager);
    -    manager.allocatePage(4096, c);  // leak memory
    +    final MemoryBlock block = manager.allocatePage(4096, c);  // leak memory
         Assert.assertEquals(4096, manager.getMemoryConsumptionForThisTask());
         Assert.assertEquals(4096, manager.cleanUpAllAllocatedMemory());
    +    manager.freePage(block, c);
    --- End diff --
    
    It should. We can check for that instead with:
    Assert.assertEquals(0, manager.cleanUpAllAllocatedMemory());


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org