[jira] [Commented] (MINIFICPP-1587) The windows-event-log extension does not compile if there is a space in the path

["Ferenc Gerlits (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MINIFICPP-1587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17358628#comment-17358628 ] 

Ferenc Gerlits commented on MINIFICPP-1587:
-------------------------------------------

As part of this task, it would be good to add some {{.gitignore}} rules so git does not list these generated files as new:
{noformat}
Untracked files:
  (use "git add <file>..." to include in what will be committed)
        extensions/windows-event-log/tests/custom-provider/unit-test-provider.cs
        extensions/windows-event-log/tests/custom-provider/unit-test-provider.dll
        extensions/windows-event-log/tests/custom-provider/unit-test-provider.h
        extensions/windows-event-log/tests/custom-provider/unit-test-provider.man
        extensions/windows-event-log/tests/custom-provider/unit-test-provider.rc
        extensions/windows-event-log/tests/custom-provider/unit-test-provider.res
        extensions/windows-event-log/tests/custom-provider/unit-test-providerTEMP.BIN
{noformat}


> The windows-event-log extension does not compile if there is a space in the path
> --------------------------------------------------------------------------------
>
>                 Key: MINIFICPP-1587
>                 URL: https://issues.apache.org/jira/browse/MINIFICPP-1587
>             Project: Apache NiFi MiNiFi C++
>          Issue Type: Bug
>            Reporter: Ferenc Gerlits
>            Priority: Minor
>             Fix For: 0.11.0
>
>
> If you check out the MiNiFi code into a directory which contains a space (e.g. {{C:\Users\Jane Doe\src\minifi}}), then the {{windows-event-log}} extension fails to compile with an error at {{CWELCustomProviderTests.cpp:37}}, with the message "error C1083: Cannot open include file: 'custom-provider/unit-test-provider.h': No such file or directory".
> This is because the {{generate-and-register.bat}} script in {{extensions/windows-event-log/tests/CMakeLists.txt}} fails, with an error similar to
> {noformat}
> Doe\src\minifi\extensions\windows-event-log\tests\custom-provider"/unit-test-provider.man" was unexpected at this time.
> {noformat}
> I suspect more quoting or escaping is needed in {{generate-and-register.bat}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)