You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/07/20 06:29:04 UTC

[GitHub] [flink] zentol commented on issue #9180: [FLINK-13331][table-planner-blink] Add CachedMiniCluster to share cluster between ITCases

zentol commented on issue #9180: [FLINK-13331][table-planner-blink] Add CachedMiniCluster to share cluster between ITCases
URL: https://github.com/apache/flink/pull/9180#issuecomment-513441557
 
 
   This approach will always leak resources as @wuchong pointed out.
   
   I have doubts whether this will improve the test times in a significant way, since we're only skipping the creation of ~60 mini clusters.
   
   Nevertheless please also provide actual numbers when doing optimizations such as this; i.e., how long did the tests take beforehand, how long do they take now, so we can gauge how valuable this change is.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services