You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/11/29 15:27:51 UTC

[GitHub] [superset] codyml commented on pull request #22250: feat: Adds overflow to the DropdownContainer popover

codyml commented on PR #22250:
URL: https://github.com/apache/superset/pull/22250#issuecomment-1330826083

   > It's not related to this PR, but while testing I crashed the dashboard :(
   > 
   > @codyml I think you modified that recently, do you know why `dataMask` might be undefined here? Should we just add a null check or can it be a deeper issue?
   
   Oops yes!  I made a typing mistake; the `DataMaskStateWithId` type should have `dataMask` as optional.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org