You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2012/05/30 02:15:57 UTC
Review Request: Removed the 'Set' gmock action and replaced it with 'Assign'.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5263/
-----------------------------------------------------------
Review request for mesos and John Sirois.
Summary
-------
See summary.
Diffs
-----
third_party/libprocess/src/tests.cpp 63be988
Diff: https://reviews.apache.org/r/5263/diff
Testing
-------
make check
Thanks,
Benjamin
Re: Review Request: Removed the 'Set' gmock action and replaced it with
'Assign'.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5263/#review8212
-----------------------------------------------------------
Ship it!
third_party/libprocess/src/tests.cpp
<https://reviews.apache.org/r/5263/#comment17760>
ws
- Vinod
On 2012-05-30 00:24:58, Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5263/
> -----------------------------------------------------------
>
> (Updated 2012-05-30 00:24:58)
>
>
> Review request for mesos, John Sirois and Vinod Kone.
>
>
> Summary
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> third_party/libprocess/src/tests.cpp 63be988
>
> Diff: https://reviews.apache.org/r/5263/diff
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin
>
>
Re: Review Request: Removed the 'Set' gmock action and replaced it with
'Assign'.
Posted by John Sirois <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5263/#review8185
-----------------------------------------------------------
Ship it!
- John
On 2012-05-30 00:24:58, Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5263/
> -----------------------------------------------------------
>
> (Updated 2012-05-30 00:24:58)
>
>
> Review request for mesos, John Sirois and Vinod Kone.
>
>
> Summary
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> third_party/libprocess/src/tests.cpp 63be988
>
> Diff: https://reviews.apache.org/r/5263/diff
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin
>
>
Re: Review Request: Removed the 'Set' gmock action and replaced it with
'Assign'.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5263/
-----------------------------------------------------------
(Updated 2012-05-30 00:24:58.715613)
Review request for mesos, John Sirois and Vinod Kone.
Changes
-------
Added Vinod as a reviewer.
Summary
-------
See summary.
Diffs
-----
third_party/libprocess/src/tests.cpp 63be988
Diff: https://reviews.apache.org/r/5263/diff
Testing
-------
make check
Thanks,
Benjamin