You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2016/04/22 21:24:29 UTC
Review Request 46580: Added uriparser as a bundled dependency.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46580/
-----------------------------------------------------------
Review request for mesos, Gilbert Song, Artem Harutyunyan, Jie Yu, and Jojy Varghese.
Bugs: MESOS-5254
https://issues.apache.org/jira/browse/MESOS-5254
Repository: mesos
Description
-------
See summary.
Diffs
-----
3rdparty/libprocess/3rdparty/Makefile.am f7aa579
3rdparty/libprocess/3rdparty/uriparser-0.8.4.tar.gz PRE-CREATION
3rdparty/libprocess/3rdparty/versions.am 5506eb3
3rdparty/libprocess/Makefile.am c51c31e
3rdparty/libprocess/configure.ac d27e46e
Diff: https://reviews.apache.org/r/46580/diff/
Testing
-------
../configure
make
make check
Thanks,
Joseph Wu
Re: Review Request 46580: Added uriparser as a bundled dependency.
Posted by Joseph Wu <jo...@mesosphere.io>.
> On April 22, 2016, 2:14 p.m., Jie Yu wrote:
> > 3rdparty/libprocess/configure.ac, line 892
> > <https://reviews.apache.org/r/46580/diff/1/?file=1357691#file1357691line892>
> >
> > Is this some specicial autoconf thing? I don't see it being used...
Oops, that's a leftover from a more rigorous check I was considering. (i.e. checking the version of `uriparser`) Forgot to remove it when I just opted to check the header.
> On April 22, 2016, 2:14 p.m., Jie Yu wrote:
> > 3rdparty/libprocess/Makefile.am, lines 189-191
> > <https://reviews.apache.org/r/46580/diff/1/?file=1357690#file1357690line189>
> >
> > Not yours, but I don't know why those are needed.
Hmm... yeah, these shouldn't be necessary with these lines (143-147) in the same file:
```
libprocess_la_LIBADD = \
$(LIBGLOG) \
$(HTTP_PARSER_LIB) \
$(EVENT_LIB) \
$(LIBURIPARSER)
```
> On April 22, 2016, 2:14 p.m., Jie Yu wrote:
> > 3rdparty/libprocess/3rdparty/Makefile.am, line 74
> > <https://reviews.apache.org/r/46580/diff/1/?file=1357687#file1357687line74>
> >
> > Can you fix the tailing `\` alignment?
Added a tab (to that blob), so that the backslashes line up with the other ones in the file.
- Joseph
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46580/#review130179
-----------------------------------------------------------
On April 22, 2016, 12:24 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46580/
> -----------------------------------------------------------
>
> (Updated April 22, 2016, 12:24 p.m.)
>
>
> Review request for mesos, Gilbert Song, Artem Harutyunyan, Jie Yu, and Jojy Varghese.
>
>
> Bugs: MESOS-5254
> https://issues.apache.org/jira/browse/MESOS-5254
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am f7aa579
> 3rdparty/libprocess/3rdparty/uriparser-0.8.4.tar.gz PRE-CREATION
> 3rdparty/libprocess/3rdparty/versions.am 5506eb3
> 3rdparty/libprocess/Makefile.am c51c31e
> 3rdparty/libprocess/configure.ac d27e46e
>
> Diff: https://reviews.apache.org/r/46580/diff/
>
>
> Testing
> -------
>
> ../configure
> make
> make check
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 46580: Added uriparser as a bundled dependency.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46580/#review130179
-----------------------------------------------------------
Fix it, then Ship it!
3rdparty/libprocess/3rdparty/Makefile.am (line 74)
<https://reviews.apache.org/r/46580/#comment193867>
Can you fix the tailing `\` alignment?
3rdparty/libprocess/Makefile.am (lines 189 - 191)
<https://reviews.apache.org/r/46580/#comment193863>
Not yours, but I don't know why those are needed.
3rdparty/libprocess/Makefile.am (lines 215 - 217)
<https://reviews.apache.org/r/46580/#comment193864>
Ditto.
3rdparty/libprocess/configure.ac (line 892)
<https://reviews.apache.org/r/46580/#comment193866>
Is this some specicial autoconf thing? I don't see it being used...
- Jie Yu
On April 22, 2016, 7:24 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46580/
> -----------------------------------------------------------
>
> (Updated April 22, 2016, 7:24 p.m.)
>
>
> Review request for mesos, Gilbert Song, Artem Harutyunyan, Jie Yu, and Jojy Varghese.
>
>
> Bugs: MESOS-5254
> https://issues.apache.org/jira/browse/MESOS-5254
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am f7aa579
> 3rdparty/libprocess/3rdparty/uriparser-0.8.4.tar.gz PRE-CREATION
> 3rdparty/libprocess/3rdparty/versions.am 5506eb3
> 3rdparty/libprocess/Makefile.am c51c31e
> 3rdparty/libprocess/configure.ac d27e46e
>
> Diff: https://reviews.apache.org/r/46580/diff/
>
>
> Testing
> -------
>
> ../configure
> make
> make check
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 46580: Added uriparser as a bundled dependency.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46580/
-----------------------------------------------------------
(Updated April 25, 2016, 4:12 p.m.)
Review request for mesos, Gilbert Song, Artem Harutyunyan, Jie Yu, and Jojy Varghese.
Changes
-------
Rebase on a change right above one of mine (merge conflict).
Bugs: MESOS-5254
https://issues.apache.org/jira/browse/MESOS-5254
Repository: mesos
Description
-------
The source for `uriparser` can be found here:
http://uriparser.sourceforge.net/
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/Makefile.am 83bd38a
3rdparty/libprocess/3rdparty/uriparser-0.8.4.tar.gz PRE-CREATION
3rdparty/libprocess/3rdparty/versions.am 5506eb3
3rdparty/libprocess/Makefile.am c51c31e
3rdparty/libprocess/configure.ac d27e46e
Diff: https://reviews.apache.org/r/46580/diff/
Testing
-------
On OSX:
../configure
make
make check
Thanks,
Joseph Wu
Re: Review Request 46580: Added uriparser as a bundled dependency.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46580/
-----------------------------------------------------------
(Updated April 22, 2016, 5:47 p.m.)
Review request for mesos, Gilbert Song, Artem Harutyunyan, Jie Yu, and Jojy Varghese.
Changes
-------
Ran build on some clean environments, fixed the resulting build errors.
Bugs: MESOS-5254
https://issues.apache.org/jira/browse/MESOS-5254
Repository: mesos
Description (updated)
-------
The source for `uriparser` can be found here:
http://uriparser.sourceforge.net/
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/Makefile.am f7aa579
3rdparty/libprocess/3rdparty/uriparser-0.8.4.tar.gz PRE-CREATION
3rdparty/libprocess/3rdparty/versions.am 5506eb3
3rdparty/libprocess/Makefile.am c51c31e
3rdparty/libprocess/configure.ac d27e46e
Diff: https://reviews.apache.org/r/46580/diff/
Testing (updated)
-------
On OSX:
../configure
make
make check
Thanks,
Joseph Wu