[GitHub] [hudi] danny0405 commented on a diff in pull request #7928: [HUDI-5772] Align Flink clustering configuration with HoodieClusteringConfig

["danny0405 (via GitHub)" <gi...@apache.org>]

danny0405 commented on code in PR #7928:
URL: https://github.com/apache/hudi/pull/7928#discussion_r1104107029


##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/configuration/FlinkOptions.java:
##########
@@ -712,6 +708,36 @@ private FlinkOptions() {
       .defaultValue(2)
       .withDescription("Number of partitions to list to create ClusteringPlan, default is 2");
 
+  public static final ConfigOption<Integer> CLUSTERING_PLAN_STRATEGY_SKIP_PARTITIONS_FROM_LATEST = ConfigOptions
+      .key("clustering.plan.strategy.daybased.skipfromlatest.partitions")
+      .intType()
+      .defaultValue(0)
+      .withDescription("Number of partitions to skip from latest when choosing partitions to create ClusteringPlan");
+
+  public static final ConfigOption<String> CLUSTERING_PLAN_STRATEGY_CLUSTER_BEGIN_PARTITION = ConfigOptions
+      .key("clustering.plan.strategy.cluster.begin.partition")
+      .stringType()
+      .noDefaultValue()

Review Comment:
   No need to add new options for flink specifically, all the hoodie options are supported automatically, see https://github.com/apache/hudi/blob/a932e482408b72b3901404027c09e2623f5a038a/hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/util/FlinkWriteClients.java#L220 for details.
   
   You can add some utilities method in `OptionsResolver` so that these option values can be fetched more easily.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org