You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@karaf.apache.org by jb...@apache.org on 2012/06/14 10:35:41 UTC
svn commit: r1350126 - in /karaf/branches/karaf-2.2.x:
jaas/command/src/main/java/org/apache/karaf/jaas/command/
jaas/modules/src/main/java/org/apache/karaf/jaas/modules/
jaas/modules/src/main/java/org/apache/karaf/jaas/modules/encryption/
jaas/modules...
Author: jbonofre
Date: Thu Jun 14 08:35:39 2012
New Revision: 1350126
URL: http://svn.apache.org/viewvc?rev=1350126&view=rev
Log:
[KARAF-1541] Fix the usage of JAAS module
Fix checkstyle
Modified:
karaf/branches/karaf-2.2.x/jaas/command/src/main/java/org/apache/karaf/jaas/command/CancelCommand.java
karaf/branches/karaf-2.2.x/jaas/command/src/main/java/org/apache/karaf/jaas/command/JaasCommandSupport.java
karaf/branches/karaf-2.2.x/jaas/command/src/main/java/org/apache/karaf/jaas/command/ListPendingCommand.java
karaf/branches/karaf-2.2.x/jaas/command/src/main/java/org/apache/karaf/jaas/command/ListRealmsCommand.java
karaf/branches/karaf-2.2.x/jaas/command/src/main/java/org/apache/karaf/jaas/command/ListUsersCommand.java
karaf/branches/karaf-2.2.x/jaas/command/src/main/java/org/apache/karaf/jaas/command/ManageRealmCommand.java
karaf/branches/karaf-2.2.x/jaas/command/src/main/java/org/apache/karaf/jaas/command/RoleAddCommand.java
karaf/branches/karaf-2.2.x/jaas/command/src/main/java/org/apache/karaf/jaas/command/RoleDeleteCommand.java
karaf/branches/karaf-2.2.x/jaas/command/src/main/java/org/apache/karaf/jaas/command/UpdateCommand.java
karaf/branches/karaf-2.2.x/jaas/command/src/main/java/org/apache/karaf/jaas/command/UserAddCommand.java
karaf/branches/karaf-2.2.x/jaas/command/src/main/java/org/apache/karaf/jaas/command/UserDeleteCommand.java
karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/AbstractKarafLoginModule.java
karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/BackingEngine.java
karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/BackingEngineFactory.java
karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/BackingEngineService.java
karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/Encryption.java
karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/GroupPrincipal.java
karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/RolePolicy.java
karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/encryption/EncryptionSupport.java
karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/jdbc/JDBCBackingEngine.java
karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/jdbc/JDBCBackingEngineFactory.java
karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/jdbc/JDBCLoginModule.java
karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/jdbc/JDBCUtils.java
karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/properties/PropertiesBackingEngine.java
karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/properties/PropertiesBackingEngineFactory.java
karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/properties/PropertiesLoginModule.java
karaf/branches/karaf-2.2.x/shell/console/src/main/java/org/apache/karaf/shell/console/completer/ArgumentCompleter.java
karaf/branches/karaf-2.2.x/tooling/testing/src/main/java/org/apache/karaf/testing/HeaderParser.java
karaf/branches/karaf-2.2.x/util/src/test/java/org/apache/karaf/util/PropertiesTest.java
Modified: karaf/branches/karaf-2.2.x/jaas/command/src/main/java/org/apache/karaf/jaas/command/CancelCommand.java
URL: http://svn.apache.org/viewvc/karaf/branches/karaf-2.2.x/jaas/command/src/main/java/org/apache/karaf/jaas/command/CancelCommand.java?rev=1350126&r1=1350125&r2=1350126&view=diff
==============================================================================
--- karaf/branches/karaf-2.2.x/jaas/command/src/main/java/org/apache/karaf/jaas/command/CancelCommand.java (original)
+++ karaf/branches/karaf-2.2.x/jaas/command/src/main/java/org/apache/karaf/jaas/command/CancelCommand.java Thu Jun 14 08:35:39 2012
@@ -13,7 +13,6 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-
package org.apache.karaf.jaas.command;
import org.apache.felix.gogo.commands.Command;
@@ -21,9 +20,6 @@ import org.apache.karaf.jaas.modules.Bac
import java.util.LinkedList;
-/**
- * @author iocanel
- */
@Command(scope = "jaas", name = "cancel", description = "Cancel the modification of a JAAS realm.")
public class CancelCommand extends JaasCommandSupport {
Modified: karaf/branches/karaf-2.2.x/jaas/command/src/main/java/org/apache/karaf/jaas/command/JaasCommandSupport.java
URL: http://svn.apache.org/viewvc/karaf/branches/karaf-2.2.x/jaas/command/src/main/java/org/apache/karaf/jaas/command/JaasCommandSupport.java?rev=1350126&r1=1350125&r2=1350126&view=diff
==============================================================================
--- karaf/branches/karaf-2.2.x/jaas/command/src/main/java/org/apache/karaf/jaas/command/JaasCommandSupport.java (original)
+++ karaf/branches/karaf-2.2.x/jaas/command/src/main/java/org/apache/karaf/jaas/command/JaasCommandSupport.java Thu Jun 14 08:35:39 2012
@@ -13,9 +13,9 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-
package org.apache.karaf.jaas.command;
+import org.apache.karaf.jaas.boot.ProxyLoginModule;
import org.apache.karaf.jaas.config.JaasRealm;
import org.apache.karaf.jaas.modules.BackingEngine;
import org.apache.karaf.jaas.modules.BackingEngineService;
@@ -25,9 +25,6 @@ import javax.security.auth.login.AppConf
import java.util.List;
import java.util.Queue;
-/**
- * @author iocanel
- */
public abstract class JaasCommandSupport extends OsgiCommandSupport {
public static final String JAAS_REALM = "JaasCommand.REALM";
@@ -91,14 +88,15 @@ public abstract class JaasCommandSupport
AppConfigurationEntry[] entries = realm.getEntries();
- //If no moduleName provided and a there is a single module in the realm.
+ // if no moduleName provided and a there is a single module in the realm.
if (entries != null && entries.length == 1 && moduleName == null) {
return entries[0];
}
- for (AppConfigurationEntry entry : entries) {
- if (moduleName.equals(entry.getLoginModuleName())) {
- return entry;
+ for (int i = 0; i < entries.length; i++) {
+ String currentModuleName = (String) entries[i].getOptions().get(ProxyLoginModule.PROPERTY_MODULE);
+ if (currentModuleName.equals(moduleName)) {
+ return entries[i];
}
}
Modified: karaf/branches/karaf-2.2.x/jaas/command/src/main/java/org/apache/karaf/jaas/command/ListPendingCommand.java
URL: http://svn.apache.org/viewvc/karaf/branches/karaf-2.2.x/jaas/command/src/main/java/org/apache/karaf/jaas/command/ListPendingCommand.java?rev=1350126&r1=1350125&r2=1350126&view=diff
==============================================================================
--- karaf/branches/karaf-2.2.x/jaas/command/src/main/java/org/apache/karaf/jaas/command/ListPendingCommand.java (original)
+++ karaf/branches/karaf-2.2.x/jaas/command/src/main/java/org/apache/karaf/jaas/command/ListPendingCommand.java Thu Jun 14 08:35:39 2012
@@ -23,15 +23,6 @@ import org.apache.karaf.jaas.boot.ProxyL
import org.apache.karaf.jaas.config.JaasRealm;
import org.apache.karaf.jaas.modules.BackingEngine;
-/**
- * @author iocanel
- */
-
-/**
- * Lists the commands the are in the command queue, for the active realm/module.
- *
- * @author iocanel
- */
@Command(scope = "jaas", name = "pending", description = "Lists the modification on the active realm/module.")
public class ListPendingCommand extends JaasCommandSupport {
Modified: karaf/branches/karaf-2.2.x/jaas/command/src/main/java/org/apache/karaf/jaas/command/ListRealmsCommand.java
URL: http://svn.apache.org/viewvc/karaf/branches/karaf-2.2.x/jaas/command/src/main/java/org/apache/karaf/jaas/command/ListRealmsCommand.java?rev=1350126&r1=1350125&r2=1350126&view=diff
==============================================================================
--- karaf/branches/karaf-2.2.x/jaas/command/src/main/java/org/apache/karaf/jaas/command/ListRealmsCommand.java (original)
+++ karaf/branches/karaf-2.2.x/jaas/command/src/main/java/org/apache/karaf/jaas/command/ListRealmsCommand.java Thu Jun 14 08:35:39 2012
@@ -23,9 +23,6 @@ import org.apache.karaf.jaas.boot.ProxyL
import org.apache.karaf.jaas.config.JaasRealm;
import org.apache.karaf.jaas.modules.BackingEngine;
-/**
- * @author iocanel
- */
@Command(scope = "jaas", name = "realms", description = "Lists the existing JAAS realms.")
public class ListRealmsCommand extends JaasCommandSupport {
Modified: karaf/branches/karaf-2.2.x/jaas/command/src/main/java/org/apache/karaf/jaas/command/ListUsersCommand.java
URL: http://svn.apache.org/viewvc/karaf/branches/karaf-2.2.x/jaas/command/src/main/java/org/apache/karaf/jaas/command/ListUsersCommand.java?rev=1350126&r1=1350125&r2=1350126&view=diff
==============================================================================
--- karaf/branches/karaf-2.2.x/jaas/command/src/main/java/org/apache/karaf/jaas/command/ListUsersCommand.java (original)
+++ karaf/branches/karaf-2.2.x/jaas/command/src/main/java/org/apache/karaf/jaas/command/ListUsersCommand.java Thu Jun 14 08:35:39 2012
@@ -24,9 +24,6 @@ import org.apache.karaf.jaas.modules.Bac
import org.apache.karaf.jaas.modules.RolePrincipal;
import org.apache.karaf.jaas.modules.UserPrincipal;
-/**
- * @author iocanel
- */
@Command(scope = "jaas", name = "users", description = "Lists the users of the active realm/module.")
public class ListUsersCommand extends JaasCommandSupport {
@@ -45,7 +42,7 @@ public class ListUsersCommand extends Ja
BackingEngine engine = backingEngineService.get(entry);
if (engine == null) {
- System.err.println(String.format("Failed to resolve backing engine for realm:%s and moudle:%s", realm.getName(), entry.getLoginModuleName()));
+ System.err.println(String.format("Failed to resolve backing engine for realm: %s and module: %s", realm.getName(), entry.getLoginModuleName()));
return null;
}
Modified: karaf/branches/karaf-2.2.x/jaas/command/src/main/java/org/apache/karaf/jaas/command/ManageRealmCommand.java
URL: http://svn.apache.org/viewvc/karaf/branches/karaf-2.2.x/jaas/command/src/main/java/org/apache/karaf/jaas/command/ManageRealmCommand.java?rev=1350126&r1=1350125&r2=1350126&view=diff
==============================================================================
--- karaf/branches/karaf-2.2.x/jaas/command/src/main/java/org/apache/karaf/jaas/command/ManageRealmCommand.java (original)
+++ karaf/branches/karaf-2.2.x/jaas/command/src/main/java/org/apache/karaf/jaas/command/ManageRealmCommand.java Thu Jun 14 08:35:39 2012
@@ -13,10 +13,8 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-
package org.apache.karaf.jaas.command;
-import org.apache.felix.gogo.commands.Argument;
import org.apache.felix.gogo.commands.Command;
import org.apache.felix.gogo.commands.Option;
import org.apache.karaf.jaas.config.JaasRealm;
@@ -26,9 +24,6 @@ import javax.security.auth.login.AppConf
import java.util.LinkedList;
import java.util.Queue;
-/**
- * @author iocanel
- */
@Command(scope = "jaas", name = "manage", description = "Manage user and roles of a Jaas Realm.")
public class ManageRealmCommand extends JaasCommandSupport {
Modified: karaf/branches/karaf-2.2.x/jaas/command/src/main/java/org/apache/karaf/jaas/command/RoleAddCommand.java
URL: http://svn.apache.org/viewvc/karaf/branches/karaf-2.2.x/jaas/command/src/main/java/org/apache/karaf/jaas/command/RoleAddCommand.java?rev=1350126&r1=1350125&r2=1350126&view=diff
==============================================================================
--- karaf/branches/karaf-2.2.x/jaas/command/src/main/java/org/apache/karaf/jaas/command/RoleAddCommand.java (original)
+++ karaf/branches/karaf-2.2.x/jaas/command/src/main/java/org/apache/karaf/jaas/command/RoleAddCommand.java Thu Jun 14 08:35:39 2012
@@ -13,18 +13,12 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-
package org.apache.karaf.jaas.command;
import org.apache.felix.gogo.commands.Argument;
import org.apache.felix.gogo.commands.Command;
import org.apache.karaf.jaas.modules.BackingEngine;
-/**
- * Adds a role to a user of the active realm/module.
- *
- * @author iocanel
- */
@Command(scope = "jaas", name = "roleadd", description = "Add a role to a user.")
public class RoleAddCommand extends JaasCommandSupport {
Modified: karaf/branches/karaf-2.2.x/jaas/command/src/main/java/org/apache/karaf/jaas/command/RoleDeleteCommand.java
URL: http://svn.apache.org/viewvc/karaf/branches/karaf-2.2.x/jaas/command/src/main/java/org/apache/karaf/jaas/command/RoleDeleteCommand.java?rev=1350126&r1=1350125&r2=1350126&view=diff
==============================================================================
--- karaf/branches/karaf-2.2.x/jaas/command/src/main/java/org/apache/karaf/jaas/command/RoleDeleteCommand.java (original)
+++ karaf/branches/karaf-2.2.x/jaas/command/src/main/java/org/apache/karaf/jaas/command/RoleDeleteCommand.java Thu Jun 14 08:35:39 2012
@@ -13,18 +13,12 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-
package org.apache.karaf.jaas.command;
import org.apache.felix.gogo.commands.Argument;
import org.apache.felix.gogo.commands.Command;
import org.apache.karaf.jaas.modules.BackingEngine;
-/**
- * Deletes a role from a user of the active realm/module.
- *
- * @author iocanel
- */
@Command(scope = "jaas", name = "roledel", description = "Delete a role from a user.")
public class RoleDeleteCommand extends JaasCommandSupport {
Modified: karaf/branches/karaf-2.2.x/jaas/command/src/main/java/org/apache/karaf/jaas/command/UpdateCommand.java
URL: http://svn.apache.org/viewvc/karaf/branches/karaf-2.2.x/jaas/command/src/main/java/org/apache/karaf/jaas/command/UpdateCommand.java?rev=1350126&r1=1350125&r2=1350126&view=diff
==============================================================================
--- karaf/branches/karaf-2.2.x/jaas/command/src/main/java/org/apache/karaf/jaas/command/UpdateCommand.java (original)
+++ karaf/branches/karaf-2.2.x/jaas/command/src/main/java/org/apache/karaf/jaas/command/UpdateCommand.java Thu Jun 14 08:35:39 2012
@@ -13,7 +13,6 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-
package org.apache.karaf.jaas.command;
import org.apache.felix.gogo.commands.Command;
@@ -24,11 +23,6 @@ import javax.security.auth.login.AppConf
import java.util.LinkedList;
import java.util.Queue;
-/**
- * Executes all the pending commands of the active realm/module.
- *
- * @author iocanel
- */
@Command(scope = "jaas", name = "update", description = "Update JAAS realm.")
public class UpdateCommand extends JaasCommandSupport {
Modified: karaf/branches/karaf-2.2.x/jaas/command/src/main/java/org/apache/karaf/jaas/command/UserAddCommand.java
URL: http://svn.apache.org/viewvc/karaf/branches/karaf-2.2.x/jaas/command/src/main/java/org/apache/karaf/jaas/command/UserAddCommand.java?rev=1350126&r1=1350125&r2=1350126&view=diff
==============================================================================
--- karaf/branches/karaf-2.2.x/jaas/command/src/main/java/org/apache/karaf/jaas/command/UserAddCommand.java (original)
+++ karaf/branches/karaf-2.2.x/jaas/command/src/main/java/org/apache/karaf/jaas/command/UserAddCommand.java Thu Jun 14 08:35:39 2012
@@ -13,18 +13,12 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-
package org.apache.karaf.jaas.command;
import org.apache.felix.gogo.commands.Argument;
import org.apache.felix.gogo.commands.Command;
import org.apache.karaf.jaas.modules.BackingEngine;
-/**
- * Creates a new user in the active realm/module.
- *
- * @author iocanel
- */
@Command(scope = "jaas", name = "useradd", description = "Add a user.")
public class UserAddCommand extends JaasCommandSupport {
Modified: karaf/branches/karaf-2.2.x/jaas/command/src/main/java/org/apache/karaf/jaas/command/UserDeleteCommand.java
URL: http://svn.apache.org/viewvc/karaf/branches/karaf-2.2.x/jaas/command/src/main/java/org/apache/karaf/jaas/command/UserDeleteCommand.java?rev=1350126&r1=1350125&r2=1350126&view=diff
==============================================================================
--- karaf/branches/karaf-2.2.x/jaas/command/src/main/java/org/apache/karaf/jaas/command/UserDeleteCommand.java (original)
+++ karaf/branches/karaf-2.2.x/jaas/command/src/main/java/org/apache/karaf/jaas/command/UserDeleteCommand.java Thu Jun 14 08:35:39 2012
@@ -13,18 +13,12 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-
package org.apache.karaf.jaas.command;
import org.apache.felix.gogo.commands.Argument;
import org.apache.felix.gogo.commands.Command;
import org.apache.karaf.jaas.modules.BackingEngine;
-/**
- * Deletes a user of the active realm/module.
- *
- * @author iocanel
- */
@Command(scope = "jaas", name = "userdel", description = "Delete a user.")
public class UserDeleteCommand extends JaasCommandSupport {
Modified: karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/AbstractKarafLoginModule.java
URL: http://svn.apache.org/viewvc/karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/AbstractKarafLoginModule.java?rev=1350126&r1=1350125&r2=1350126&view=diff
==============================================================================
--- karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/AbstractKarafLoginModule.java (original)
+++ karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/AbstractKarafLoginModule.java Thu Jun 14 08:35:39 2012
@@ -26,14 +26,6 @@ import java.util.HashSet;
import java.util.Map;
import java.util.Set;
-
-/**
- * <p>
- * Abstract JAAS login module extended by all Karaf Login Modules.
- * </p>
- *
- * @author iocanel, jbonofre
- */
public abstract class AbstractKarafLoginModule implements LoginModule {
protected Set<Principal> principals = new HashSet<Principal>();
Modified: karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/BackingEngine.java
URL: http://svn.apache.org/viewvc/karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/BackingEngine.java?rev=1350126&r1=1350125&r2=1350126&view=diff
==============================================================================
--- karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/BackingEngine.java (original)
+++ karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/BackingEngine.java Thu Jun 14 08:35:39 2012
@@ -16,12 +16,8 @@ package org.apache.karaf.jaas.modules;
import java.util.List;
-/**
- * @author iocanel
- */
public interface BackingEngine {
-
/**
* Create a new User.
*
Modified: karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/BackingEngineFactory.java
URL: http://svn.apache.org/viewvc/karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/BackingEngineFactory.java?rev=1350126&r1=1350125&r2=1350126&view=diff
==============================================================================
--- karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/BackingEngineFactory.java (original)
+++ karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/BackingEngineFactory.java Thu Jun 14 08:35:39 2012
@@ -17,9 +17,6 @@ package org.apache.karaf.jaas.modules;
import java.util.Map;
-/**
- * @author iocanel
- */
public interface BackingEngineFactory {
/**
Modified: karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/BackingEngineService.java
URL: http://svn.apache.org/viewvc/karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/BackingEngineService.java?rev=1350126&r1=1350125&r2=1350126&view=diff
==============================================================================
--- karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/BackingEngineService.java (original)
+++ karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/BackingEngineService.java Thu Jun 14 08:35:39 2012
@@ -13,7 +13,6 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-
package org.apache.karaf.jaas.modules;
import org.apache.karaf.jaas.boot.ProxyLoginModule;
@@ -21,9 +20,6 @@ import org.apache.karaf.jaas.boot.ProxyL
import javax.security.auth.login.AppConfigurationEntry;
import java.util.List;
-/**
- * @author iocanel
- */
public class BackingEngineService {
private List<BackingEngineFactory> engineFactories;
Modified: karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/Encryption.java
URL: http://svn.apache.org/viewvc/karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/Encryption.java?rev=1350126&r1=1350125&r2=1350126&view=diff
==============================================================================
--- karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/Encryption.java (original)
+++ karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/Encryption.java Thu Jun 14 08:35:39 2012
@@ -14,13 +14,6 @@
*/
package org.apache.karaf.jaas.modules;
-/**
- * <p>
- * Interface describing the password encryption service.
- * </>
- *
- * @author jbonofre
- */
public interface Encryption {
/**
Modified: karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/GroupPrincipal.java
URL: http://svn.apache.org/viewvc/karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/GroupPrincipal.java?rev=1350126&r1=1350125&r2=1350126&view=diff
==============================================================================
--- karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/GroupPrincipal.java (original)
+++ karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/GroupPrincipal.java Thu Jun 14 08:35:39 2012
@@ -12,7 +12,6 @@
* limitations under the License.
* under the License.
*/
-
package org.apache.karaf.jaas.modules;
import java.security.Principal;
@@ -20,10 +19,6 @@ import java.security.acl.Group;
import java.util.Enumeration;
import java.util.Hashtable;
-/**
- *
- * @author iocanel
- */
public class GroupPrincipal implements Group {
private String name;
Modified: karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/RolePolicy.java
URL: http://svn.apache.org/viewvc/karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/RolePolicy.java?rev=1350126&r1=1350125&r2=1350126&view=diff
==============================================================================
--- karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/RolePolicy.java (original)
+++ karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/RolePolicy.java Thu Jun 14 08:35:39 2012
@@ -12,7 +12,6 @@
* limitations under the License.
* under the License.
*/
-
package org.apache.karaf.jaas.modules;
import java.security.Principal;
@@ -23,10 +22,6 @@ import java.util.Map;
import java.util.Set;
import javax.security.auth.Subject;
-/**
- *
- * @author iocanel
- */
public enum RolePolicy {
PREFIXED_ROLES("prefix") {
Modified: karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/encryption/EncryptionSupport.java
URL: http://svn.apache.org/viewvc/karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/encryption/EncryptionSupport.java?rev=1350126&r1=1350125&r2=1350126&view=diff
==============================================================================
--- karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/encryption/EncryptionSupport.java (original)
+++ karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/encryption/EncryptionSupport.java Thu Jun 14 08:35:39 2012
@@ -26,9 +26,6 @@ import java.util.Arrays;
import java.util.HashMap;
import java.util.Map;
-/**
- * @author iocanel
- */
public class EncryptionSupport {
private final Logger logger = LoggerFactory.getLogger(EncryptionSupport.class);
Modified: karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/jdbc/JDBCBackingEngine.java
URL: http://svn.apache.org/viewvc/karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/jdbc/JDBCBackingEngine.java?rev=1350126&r1=1350125&r2=1350126&view=diff
==============================================================================
--- karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/jdbc/JDBCBackingEngine.java (original)
+++ karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/jdbc/JDBCBackingEngine.java Thu Jun 14 08:35:39 2012
@@ -13,7 +13,6 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-
package org.apache.karaf.jaas.modules.jdbc;
import org.apache.karaf.jaas.modules.BackingEngine;
@@ -31,9 +30,6 @@ import java.sql.SQLException;
import java.util.ArrayList;
import java.util.List;
-/**
- * @author iocanel, jbonofre
- */
public class JDBCBackingEngine implements BackingEngine {
private final Logger logger = LoggerFactory.getLogger(JDBCBackingEngine.class);
Modified: karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/jdbc/JDBCBackingEngineFactory.java
URL: http://svn.apache.org/viewvc/karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/jdbc/JDBCBackingEngineFactory.java?rev=1350126&r1=1350125&r2=1350126&view=diff
==============================================================================
--- karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/jdbc/JDBCBackingEngineFactory.java (original)
+++ karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/jdbc/JDBCBackingEngineFactory.java Thu Jun 14 08:35:39 2012
@@ -13,7 +13,6 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-
package org.apache.karaf.jaas.modules.jdbc;
import org.apache.karaf.jaas.modules.BackingEngine;
@@ -26,9 +25,6 @@ import org.slf4j.LoggerFactory;
import javax.sql.DataSource;
import java.util.Map;
-/**
- * @author iocanel
- */
public class JDBCBackingEngineFactory implements BackingEngineFactory {
private final Logger logger = LoggerFactory.getLogger(JDBCBackingEngineFactory.class);
Modified: karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/jdbc/JDBCLoginModule.java
URL: http://svn.apache.org/viewvc/karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/jdbc/JDBCLoginModule.java?rev=1350126&r1=1350125&r2=1350126&view=diff
==============================================================================
--- karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/jdbc/JDBCLoginModule.java (original)
+++ karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/jdbc/JDBCLoginModule.java Thu Jun 14 08:35:39 2012
@@ -36,9 +36,6 @@ import java.sql.SQLException;
import java.util.HashSet;
import java.util.Map;
-/**
- * @author iocanel
- */
public class JDBCLoginModule extends AbstractKarafLoginModule {
private final Logger logger = LoggerFactory.getLogger(PropertiesLoginModule.class);
Modified: karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/jdbc/JDBCUtils.java
URL: http://svn.apache.org/viewvc/karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/jdbc/JDBCUtils.java?rev=1350126&r1=1350125&r2=1350126&view=diff
==============================================================================
--- karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/jdbc/JDBCUtils.java (original)
+++ karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/jdbc/JDBCUtils.java Thu Jun 14 08:35:39 2012
@@ -13,7 +13,6 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-
package org.apache.karaf.jaas.modules.jdbc;
import org.osgi.framework.BundleContext;
@@ -21,9 +20,6 @@ import org.osgi.framework.ServiceReferen
import javax.naming.InitialContext;
-/**
- * @author iocanel
- */
public final class JDBCUtils {
public static final String DATASOURCE = "datasource";
Modified: karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/properties/PropertiesBackingEngine.java
URL: http://svn.apache.org/viewvc/karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/properties/PropertiesBackingEngine.java?rev=1350126&r1=1350125&r2=1350126&view=diff
==============================================================================
--- karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/properties/PropertiesBackingEngine.java (original)
+++ karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/properties/PropertiesBackingEngine.java Thu Jun 14 08:35:39 2012
@@ -13,7 +13,6 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-
package org.apache.karaf.jaas.modules.properties;
import org.apache.karaf.jaas.modules.BackingEngine;
@@ -27,10 +26,6 @@ import org.slf4j.LoggerFactory;
import java.util.ArrayList;
import java.util.List;
-
-/**
- * @author iocanel
- */
public class PropertiesBackingEngine implements BackingEngine {
private final Logger logger = LoggerFactory.getLogger(PropertiesBackingEngine.class);
Modified: karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/properties/PropertiesBackingEngineFactory.java
URL: http://svn.apache.org/viewvc/karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/properties/PropertiesBackingEngineFactory.java?rev=1350126&r1=1350125&r2=1350126&view=diff
==============================================================================
--- karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/properties/PropertiesBackingEngineFactory.java (original)
+++ karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/properties/PropertiesBackingEngineFactory.java Thu Jun 14 08:35:39 2012
@@ -13,7 +13,6 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-
package org.apache.karaf.jaas.modules.properties;
import org.apache.karaf.jaas.modules.BackingEngine;
@@ -27,9 +26,6 @@ import java.io.File;
import java.io.IOException;
import java.util.Map;
-/**
- * @author iocanel
- */
public class PropertiesBackingEngineFactory implements BackingEngineFactory {
private final Logger logger = LoggerFactory.getLogger(PropertiesBackingEngineFactory.class);
Modified: karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/properties/PropertiesLoginModule.java
URL: http://svn.apache.org/viewvc/karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/properties/PropertiesLoginModule.java?rev=1350126&r1=1350125&r2=1350126&view=diff
==============================================================================
--- karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/properties/PropertiesLoginModule.java (original)
+++ karaf/branches/karaf-2.2.x/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/properties/PropertiesLoginModule.java Thu Jun 14 08:35:39 2012
@@ -37,13 +37,6 @@ import org.apache.karaf.util.Properties;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-/**
- * <p>
- * JAAS Login module for user / password, based on two properties files.
- * </p>
- *
- * @author gnodet, jbonofre
- */
public class PropertiesLoginModule extends AbstractKarafLoginModule {
private final Logger LOG = LoggerFactory.getLogger(PropertiesLoginModule.class);
Modified: karaf/branches/karaf-2.2.x/shell/console/src/main/java/org/apache/karaf/shell/console/completer/ArgumentCompleter.java
URL: http://svn.apache.org/viewvc/karaf/branches/karaf-2.2.x/shell/console/src/main/java/org/apache/karaf/shell/console/completer/ArgumentCompleter.java?rev=1350126&r1=1350125&r2=1350126&view=diff
==============================================================================
--- karaf/branches/karaf-2.2.x/shell/console/src/main/java/org/apache/karaf/shell/console/completer/ArgumentCompleter.java (original)
+++ karaf/branches/karaf-2.2.x/shell/console/src/main/java/org/apache/karaf/shell/console/completer/ArgumentCompleter.java Thu Jun 14 08:35:39 2012
@@ -386,8 +386,6 @@ public class ArgumentCompleter implement
/**
* The result of a delimited buffer.
- *
- * @author <a href="mailto:mwp1@cornell.edu">Marc Prud'hommeaux</a>
*/
public static class ArgumentList {
private String[] arguments;
Modified: karaf/branches/karaf-2.2.x/tooling/testing/src/main/java/org/apache/karaf/testing/HeaderParser.java
URL: http://svn.apache.org/viewvc/karaf/branches/karaf-2.2.x/tooling/testing/src/main/java/org/apache/karaf/testing/HeaderParser.java?rev=1350126&r1=1350125&r2=1350126&view=diff
==============================================================================
--- karaf/branches/karaf-2.2.x/tooling/testing/src/main/java/org/apache/karaf/testing/HeaderParser.java (original)
+++ karaf/branches/karaf-2.2.x/tooling/testing/src/main/java/org/apache/karaf/testing/HeaderParser.java Thu Jun 14 08:35:39 2012
@@ -30,9 +30,6 @@ import java.util.jar.Manifest;
/**
* Utility class to parse a standard OSGi header with paths.
- *
- * @author <a href="mailto:dev@geronimo.apache.org">Apache Geronimo Project</a>
- * @version $Rev: 786132 $, $Date: 2009-06-18 17:47:58 +0200 (Thu, 18 Jun 2009) $
*/
public final class HeaderParser {
Modified: karaf/branches/karaf-2.2.x/util/src/test/java/org/apache/karaf/util/PropertiesTest.java
URL: http://svn.apache.org/viewvc/karaf/branches/karaf-2.2.x/util/src/test/java/org/apache/karaf/util/PropertiesTest.java?rev=1350126&r1=1350125&r2=1350126&view=diff
==============================================================================
--- karaf/branches/karaf-2.2.x/util/src/test/java/org/apache/karaf/util/PropertiesTest.java (original)
+++ karaf/branches/karaf-2.2.x/util/src/test/java/org/apache/karaf/util/PropertiesTest.java Thu Jun 14 08:35:39 2012
@@ -23,13 +23,6 @@ import java.io.StringWriter;
import junit.framework.TestCase;
-/**
- * <p>
- * Unit tests on <code>Properties</code>.
- * </p>
- *
- * @author jbonofre
- */
public class PropertiesTest extends TestCase {
private final static String TEST_PROPERTIES_FILE = "test.properties";