You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Johan Oskarsson (JIRA)" <ji...@apache.org> on 2008/12/02 20:20:44 UTC
[jira] Created: (HIVE-102) Refactor DDLTask
Refactor DDLTask
----------------
Key: HIVE-102
URL: https://issues.apache.org/jira/browse/HIVE-102
Project: Hadoop Hive
Issue Type: Improvement
Components: Query Processor
Reporter: Johan Oskarsson
Priority: Minor
Fix For: 0.20.0
DDLTask have one method that is around 400 lines long. Refactor the if statements into methods to increase readability.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-102) Refactor DDLTask
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12653095#action_12653095 ]
Namit Jain commented on HIVE-102:
---------------------------------
+1
> Refactor DDLTask
> ----------------
>
> Key: HIVE-102
> URL: https://issues.apache.org/jira/browse/HIVE-102
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Query Processor
> Reporter: Johan Oskarsson
> Assignee: Johan Oskarsson
> Priority: Minor
> Fix For: 0.20.0
>
> Attachments: HIVE-102.patch, HIVE-102.patch
>
>
> DDLTask have one method that is around 400 lines long. Refactor the if statements into methods to increase readability.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-102) Refactor DDLTask
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-102:
--------------------------------
Fix Version/s: 0.3.0
(was: 0.6.0)
> Refactor DDLTask
> ----------------
>
> Key: HIVE-102
> URL: https://issues.apache.org/jira/browse/HIVE-102
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Query Processor
> Reporter: Johan Oskarsson
> Assignee: Johan Oskarsson
> Priority: Minor
> Fix For: 0.3.0
>
> Attachments: HIVE-102.patch, HIVE-102.patch
>
>
> DDLTask have one method that is around 400 lines long. Refactor the if statements into methods to increase readability.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-102) Refactor DDLTask
Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654331#action_12654331 ]
Zheng Shao commented on HIVE-102:
---------------------------------
Committed revision 724266.
Thanks Johan!
> Refactor DDLTask
> ----------------
>
> Key: HIVE-102
> URL: https://issues.apache.org/jira/browse/HIVE-102
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Query Processor
> Reporter: Johan Oskarsson
> Assignee: Johan Oskarsson
> Priority: Minor
> Fix For: 0.20.0
>
> Attachments: HIVE-102.patch, HIVE-102.patch
>
>
> DDLTask have one method that is around 400 lines long. Refactor the if statements into methods to increase readability.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-102) Refactor DDLTask
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12653015#action_12653015 ]
Namit Jain commented on HIVE-102:
---------------------------------
Yes, going forward, we are trying to enforce that.
> Refactor DDLTask
> ----------------
>
> Key: HIVE-102
> URL: https://issues.apache.org/jira/browse/HIVE-102
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Query Processor
> Reporter: Johan Oskarsson
> Assignee: Johan Oskarsson
> Priority: Minor
> Fix For: 0.20.0
>
> Attachments: HIVE-102.patch
>
>
> DDLTask have one method that is around 400 lines long. Refactor the if statements into methods to increase readability.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-102) Refactor DDLTask
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12653002#action_12653002 ]
Namit Jain commented on HIVE-102:
---------------------------------
Looks good. Can you add some comments for each of the functions ? After that, it should be good to go.
Also, can you add java docs for each of these new functions that you added.
Eventually, it might be good to break it up into separate tasks. The abstract class DDLWork can have various subclasses:
showTablesWork, DescribeTableWork etc. and a separate task for each of them. This will make them completely independent.
However, that can be done in a follow-up
> Refactor DDLTask
> ----------------
>
> Key: HIVE-102
> URL: https://issues.apache.org/jira/browse/HIVE-102
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Query Processor
> Reporter: Johan Oskarsson
> Assignee: Johan Oskarsson
> Priority: Minor
> Fix For: 0.20.0
>
> Attachments: HIVE-102.patch
>
>
> DDLTask have one method that is around 400 lines long. Refactor the if statements into methods to increase readability.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-102) Refactor DDLTask
Posted by "Johan Oskarsson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Johan Oskarsson updated HIVE-102:
---------------------------------
Attachment: HIVE-102.patch
Updated patch with javadocs for the new methods.
> Refactor DDLTask
> ----------------
>
> Key: HIVE-102
> URL: https://issues.apache.org/jira/browse/HIVE-102
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Query Processor
> Reporter: Johan Oskarsson
> Assignee: Johan Oskarsson
> Priority: Minor
> Fix For: 0.20.0
>
> Attachments: HIVE-102.patch, HIVE-102.patch
>
>
> DDLTask have one method that is around 400 lines long. Refactor the if statements into methods to increase readability.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-102) Refactor DDLTask
Posted by "Johan Oskarsson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Johan Oskarsson updated HIVE-102:
---------------------------------
Status: Patch Available (was: Open)
> Refactor DDLTask
> ----------------
>
> Key: HIVE-102
> URL: https://issues.apache.org/jira/browse/HIVE-102
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Query Processor
> Reporter: Johan Oskarsson
> Priority: Minor
> Fix For: 0.20.0
>
> Attachments: HIVE-102.patch
>
>
> DDLTask have one method that is around 400 lines long. Refactor the if statements into methods to increase readability.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-102) Refactor DDLTask
Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12653598#action_12653598 ]
Zheng Shao commented on HIVE-102:
---------------------------------
Namit, is https://issues.apache.org/jira/browse/HIVE-123 a duplicate of this?
> Refactor DDLTask
> ----------------
>
> Key: HIVE-102
> URL: https://issues.apache.org/jira/browse/HIVE-102
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Query Processor
> Reporter: Johan Oskarsson
> Assignee: Johan Oskarsson
> Priority: Minor
> Fix For: 0.20.0
>
> Attachments: HIVE-102.patch, HIVE-102.patch
>
>
> DDLTask have one method that is around 400 lines long. Refactor the if statements into methods to increase readability.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-102) Refactor DDLTask
Posted by "Johan Oskarsson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12653012#action_12653012 ]
Johan Oskarsson commented on HIVE-102:
--------------------------------------
Sure, will do. Is the practice to add Javadoc comments for all private methods?
> Refactor DDLTask
> ----------------
>
> Key: HIVE-102
> URL: https://issues.apache.org/jira/browse/HIVE-102
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Query Processor
> Reporter: Johan Oskarsson
> Assignee: Johan Oskarsson
> Priority: Minor
> Fix For: 0.20.0
>
> Attachments: HIVE-102.patch
>
>
> DDLTask have one method that is around 400 lines long. Refactor the if statements into methods to increase readability.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-102) Refactor DDLTask
Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zheng Shao updated HIVE-102:
----------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
HIVE-102. Refactor DDLTask. (Johan Oskarsson through zshao)
> Refactor DDLTask
> ----------------
>
> Key: HIVE-102
> URL: https://issues.apache.org/jira/browse/HIVE-102
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Query Processor
> Reporter: Johan Oskarsson
> Assignee: Johan Oskarsson
> Priority: Minor
> Fix For: 0.20.0
>
> Attachments: HIVE-102.patch, HIVE-102.patch
>
>
> DDLTask have one method that is around 400 lines long. Refactor the if statements into methods to increase readability.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-102) Refactor DDLTask
Posted by "Johan Oskarsson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Johan Oskarsson updated HIVE-102:
---------------------------------
Attachment: HIVE-102.patch
I've refactored the execute method using eclipse's extract method to simply split it up into one method per operation.
> Refactor DDLTask
> ----------------
>
> Key: HIVE-102
> URL: https://issues.apache.org/jira/browse/HIVE-102
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Query Processor
> Reporter: Johan Oskarsson
> Priority: Minor
> Fix For: 0.20.0
>
> Attachments: HIVE-102.patch
>
>
> DDLTask have one method that is around 400 lines long. Refactor the if statements into methods to increase readability.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-102) Refactor DDLTask
Posted by "Johan Oskarsson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654128#action_12654128 ]
Johan Oskarsson commented on HIVE-102:
--------------------------------------
Zheng: Namit mention in HIVE-123 that it is a continuation of this ticket, so this could be committed first.
> Refactor DDLTask
> ----------------
>
> Key: HIVE-102
> URL: https://issues.apache.org/jira/browse/HIVE-102
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Query Processor
> Reporter: Johan Oskarsson
> Assignee: Johan Oskarsson
> Priority: Minor
> Fix For: 0.20.0
>
> Attachments: HIVE-102.patch, HIVE-102.patch
>
>
> DDLTask have one method that is around 400 lines long. Refactor the if statements into methods to increase readability.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-102) Refactor DDLTask
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654265#action_12654265 ]
Namit Jain commented on HIVE-102:
---------------------------------
+1
> Refactor DDLTask
> ----------------
>
> Key: HIVE-102
> URL: https://issues.apache.org/jira/browse/HIVE-102
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Query Processor
> Reporter: Johan Oskarsson
> Assignee: Johan Oskarsson
> Priority: Minor
> Fix For: 0.20.0
>
> Attachments: HIVE-102.patch, HIVE-102.patch
>
>
> DDLTask have one method that is around 400 lines long. Refactor the if statements into methods to increase readability.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HIVE-102) Refactor DDLTask
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Namit Jain reassigned HIVE-102:
-------------------------------
Assignee: Johan Oskarsson
> Refactor DDLTask
> ----------------
>
> Key: HIVE-102
> URL: https://issues.apache.org/jira/browse/HIVE-102
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Query Processor
> Reporter: Johan Oskarsson
> Assignee: Johan Oskarsson
> Priority: Minor
> Fix For: 0.20.0
>
> Attachments: HIVE-102.patch
>
>
> DDLTask have one method that is around 400 lines long. Refactor the if statements into methods to increase readability.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.