You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hive.apache.org by "Ajith S (Jira)" <ji...@apache.org> on 2020/02/26 11:34:00 UTC

[jira] [Commented] (HIVE-17307) Change the metastore to not use the metrics code in hive/common

    [ https://issues.apache.org/jira/browse/HIVE-17307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17045404#comment-17045404 ] 

Ajith S commented on HIVE-17307:
--------------------------------

[~gates] [~vgarg] [~vihangk1] thanks for the patch guys

just a question about the threadpool used in HMSHandler, [https://github.com/apache/hive/blob/release-3.1.3-rc0/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java#L582] does this have to be non-daemon.? as it may cause the main thread to not exit 

> Change the metastore to not use the metrics code in hive/common
> ---------------------------------------------------------------
>
>                 Key: HIVE-17307
>                 URL: https://issues.apache.org/jira/browse/HIVE-17307
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Standalone Metastore
>            Reporter: Alan Gates
>            Assignee: Alan Gates
>            Priority: Major
>             Fix For: 3.0.0
>
>         Attachments: HIVE-17307.2.patch, HIVE-17307.3.patch, HIVE-17307.4.patch, HIVE-17307.5.patch, HIVE-17307.patch
>
>
> As we move code into the standalone metastore module, it cannot use the metrics in hive-common.  We could copy the current Metrics interface or we could change the metastore code to directly use codahale metrics.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)