You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "HappenLee (via GitHub)" <gi...@apache.org> on 2023/01/29 05:59:26 UTC
[GitHub] [doris] HappenLee opened a new pull request, #16190: [Enhance] use std::from_chars to do str cast to float/double to avoid lose precision
HappenLee opened a new pull request, #16190:
URL: https://github.com/apache/doris/pull/16190
# Proposed changes
load data.csv
```
1.14
```
select * from table
```
1.1400000000000001
```
after the fix
select * from table
```
1.14
```
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16190: [Enhance](fix)use std::from_chars to do str cast to float/double to avoid lose precision
Posted by github-actions.
github-actions[bot] commented on PR #16190:
URL: https://github.com/apache/doris/pull/16190#issuecomment-1411580688
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16190: [Enhance](fix)use std::from_chars to do str cast to float/double to avoid lose precision
Posted by github-actions.
github-actions[bot] commented on PR #16190:
URL: https://github.com/apache/doris/pull/16190#issuecomment-1411580629
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #16190: [Enhance](fix)use std::from_chars to do str cast to float/double to avoid lose precision
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #16190:
URL: https://github.com/apache/doris/pull/16190#issuecomment-1407594894
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.03 seconds
load time: 506 seconds
storage size: 17122424421 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230129081328_clickbench_pr_86141.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] HappenLee merged pull request #16190: [Enhance](fix)use std::from_chars to do str cast to float/double to avoid lose precision
Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee merged PR #16190:
URL: https://github.com/apache/doris/pull/16190
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16190: [Enhance](fix)use std::from_chars to do str cast to float/double to avoid lose precision
Posted by github-actions.
github-actions[bot] commented on PR #16190:
URL: https://github.com/apache/doris/pull/16190#issuecomment-1407581461
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16190: [Enhance] use std::from_chars to do str cast to float/double to avoid lose precision
Posted by github-actions.
github-actions[bot] commented on PR #16190:
URL: https://github.com/apache/doris/pull/16190#issuecomment-1407571847
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #16190: [Enhance](fix)use std::from_chars to do str cast to float/double to avoid lose precision
Posted by github-actions.
github-actions[bot] commented on code in PR #16190:
URL: https://github.com/apache/doris/pull/16190#discussion_r1089910051
##########
be/src/util/string_parser.hpp:
##########
@@ -20,6 +20,8 @@
#pragma once
+#include <fast_float/fast_float.h>
Review Comment:
warning: 'fast_float/fast_float.h' file not found [clang-diagnostic-error]
```cpp
#include <fast_float/fast_float.h>
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16190: [Enhance](fix)use std::from_chars to do str cast to float/double to avoid lose precision
Posted by github-actions.
github-actions[bot] commented on PR #16190:
URL: https://github.com/apache/doris/pull/16190#issuecomment-1407579772
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16190: [Enhance](fix)use std::from_chars to do str cast to float/double to avoid lose precision
Posted by github-actions.
github-actions[bot] commented on PR #16190:
URL: https://github.com/apache/doris/pull/16190#issuecomment-1407575493
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16190: [Enhance](fix)use std::from_chars to do str cast to float/double to avoid lose precision
Posted by github-actions.
github-actions[bot] commented on PR #16190:
URL: https://github.com/apache/doris/pull/16190#issuecomment-1411336520
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org