[GitHub] [arrow-datafusion] Jimexist commented on a change in pull request #289: Add csv mode to datafusion cli

[GitBox <gi...@apache.org>]

Jimexist commented on a change in pull request #289:
URL: https://github.com/apache/arrow-datafusion/pull/289#discussion_r628736917



##########
File path: datafusion-cli/src/main.rs
##########
@@ -51,6 +56,20 @@ pub async fn main() {
                 .validator(is_valid_batch_size)
                 .takes_value(true),
         )
+        .arg(
+            Arg::with_name("file")
+                .help("Execute commands from file, then exit")
+                .short("f")
+                .long("file")
+                .validator(is_valid_file)
+                .takes_value(true),
+        )
+        .arg(

Review comment:
       I'm following `psql` convention. Deviation from that is okay but would be a thoughtful decision.
   
   So far `psql` is a bit messy because you can have `csv`, `aligned` which is table, `unaligned` which is `|` separated values. In an ideal world we should strive for `csv`, `table`, `json`, `row-json` which is basically transposed json, and some more. WDYT? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org