You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2022/10/21 05:23:22 UTC

[GitHub] [dubbo-go] aeternae opened a new issue, #2086: client不支持ms级别的timeout

aeternae opened a new issue, #2086:
URL: https://github.com/apache/dubbo-go/issues/2086

   <!-- Please only use this template for submitting enhancement requests -->
   opts := []triConfig.OptionFunction{
   		triConfig.WithClientTimeout(uint32(timeout.Seconds())),
   		triConfig.WithCodecType(triCodecType),
   		triConfig.WithLocation(url.Location),
   		triConfig.WithHeaderAppVersion(url.GetParam(constant.AppVersionKey, "")),
   		triConfig.WithHeaderGroup(url.GetParam(constant.GroupKey, "")),
   		triConfig.WithLogger(logger.GetLogger()),
   	}
   ms级别的timeout会被转化成秒级后,被uint32类型转化成0值
   
   func (o *Option) Validate() {
   	if o.Timeout == uint32(0) {
   		o.Timeout = uint32(constant.DefaultTimeout)
   	}
          ...
   }
   0值被修改成默认的15s
   
   **What would you like to be added**:
   
   **Why is this needed**:


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo-go] zhaoyunxing92 commented on issue #2086: client不支持ms级别的timeout

Posted by GitBox <gi...@apache.org>.
zhaoyunxing92 commented on issue #2086:
URL: https://github.com/apache/dubbo-go/issues/2086#issuecomment-1298757861

   我建议修改`WithClientTimeout`的参数类型会比较合理点


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo-go] zhaoyunxing92 closed issue #2086: client不支持ms级别的timeout

Posted by GitBox <gi...@apache.org>.
zhaoyunxing92 closed issue #2086: client不支持ms级别的timeout
URL: https://github.com/apache/dubbo-go/issues/2086


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org