You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by GitBox <gi...@apache.org> on 2020/05/27 04:02:13 UTC
[GitHub] [qpid-proton] jiridanek opened a new pull request #250: PROTON-2225: compile c-threaderciser with COMPILE_LANGUAGE_FLAGS
jiridanek opened a new pull request #250:
URL: https://github.com/apache/qpid-proton/pull/250
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-proton] jiridanek commented on a change in pull request #250: PROTON-2225: compile c-threaderciser with COMPILE_LANGUAGE_FLAGS
Posted by GitBox <gi...@apache.org>.
jiridanek commented on a change in pull request #250:
URL: https://github.com/apache/qpid-proton/pull/250#discussion_r430670130
##########
File path: c/tests/CMakeLists.txt
##########
@@ -88,7 +88,8 @@ if (CMAKE_CXX_COMPILER)
option(THREADERCISER "Run the threaderciser concurrency tests" ${DEFAULT_THREADERCISER})
if (THREADERCISER)
add_executable(c-threaderciser threaderciser.c)
- set_target_properties(c-threaderciser PROPERTIES COMPILE_FLAGS "${CMAKE_C_FLAGS} ${C_WARNING_FLAGS}")
+ set_target_properties(c-threaderciser
+ PROPERTIES COMPILE_FLAGS "${COMPILE_LANGUAGE_FLAGS} ${CMAKE_C_FLAGS} ${C_WARNING_FLAGS}")
Review comment:
```suggestion
set_target_properties(c-threaderciser
PROPERTIES COMPILE_FLAGS "${COMPILE_LANGUAGE_FLAGS} ${CMAKE_C_FLAGS} ${C_WARNING_FLAGS}")
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-proton] jiridanek merged pull request #250: PROTON-2225: compile c-threaderciser with COMPILE_LANGUAGE_FLAGS
Posted by GitBox <gi...@apache.org>.
jiridanek merged pull request #250:
URL: https://github.com/apache/qpid-proton/pull/250
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org