[GitHub] [druid] cryptoe commented on a change in pull request #11978: Fix classNotFoundException when connecting to secure LDAP

[GitBox <gi...@apache.org>]

cryptoe commented on a change in pull request #11978:
URL: https://github.com/apache/druid/pull/11978#discussion_r754988353



##########
File path: extensions-core/druid-basic-security/src/main/java/org/apache/druid/security/basic/authentication/validator/LDAPCredentialsValidator.java
##########
@@ -213,8 +221,10 @@ SearchResult getLdapUserObject(BasicAuthLDAPConfig ldapConfig, DirContext contex
   boolean validatePassword(BasicAuthLDAPConfig ldapConfig, LdapName userDn, char[] password)
   {
     InitialDirContext context = null;
+    ClassLoader currentClassLoader = Thread.currentThread().getContextClassLoader();

Review comment:
       nit: Can't we remove setting the classloader here ? 
   Push the finally block after `validatePassword` and change the `validatePassword` scope to private ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org