Build Results: Win2K & Linux -- FYI -- MINOR BUG FOUND in W2K

[Ian Holsman <ia...@cnet.com>]

Using standard apache build + proxy + mod_status

Win2K build results:
1 warning in standard apache build in http_protocol (seperate email)
1 warning in mod_proxy (connect call)

and that was it... vast improvement from a month ago...



Win2K: build OK, runs OK
Linux: build OK, runs OK

when running ab.exe (win2k) against the linux machine, I ran into a GPF.
in function:
apr_sockaddr_info_get (line 458)

save_addr_info is called and 'hp' is null. (passed a hostname which was 
defined in \winnt\system32\drivers\etc\hosts
and not a name server)

this should fix it.
..Ian
I'm happy with both of these platforms..

Index: network_io/unix/sa_common.c
===================================================================
RCS file: /home/cvspublic/apr/network_io/unix/sa_common.c,v
retrieving revision 1.42
diff -u -r1.42 sa_common.c
--- network_io/unix/sa_common.c 2001/08/01 18:03:33     1.42
+++ network_io/unix/sa_common.c 2001/08/08 05:25:24
@@ -439,7 +439,7 @@

         if (!hp)  {
 #ifdef WIN32
-            apr_get_netos_error();
+            return apr_get_netos_error();
 #elif APR_HAS_THREADS && !defined(GETHOSTBYNAME_IS_THREAD_SAFE) && \
     defined(HAVE_GETHOSTBYNAME_R) && !defined(BEOS)
 #ifdef GETHOSTBYNAME_R_HOSTENT_DATA

Re: Build Results: Win2K & Linux -- FYI -- MINOR BUG FOUND in W2K

[Cliff Woolley <cl...@yahoo.com>]

On Tue, 7 Aug 2001, Ian Holsman wrote:

> Index: network_io/unix/sa_common.c
> ===================================================================
> RCS file: /home/cvspublic/apr/network_io/unix/sa_common.c,v
> retrieving revision 1.42
> diff -u -r1.42 sa_common.c
> --- network_io/unix/sa_common.c 2001/08/01 18:03:33     1.42
> +++ network_io/unix/sa_common.c 2001/08/08 05:25:24
> @@ -439,7 +439,7 @@
>
>          if (!hp)  {
>  #ifdef WIN32
> -            apr_get_netos_error();
> +            return apr_get_netos_error();
>  #elif APR_HAS_THREADS && !defined(GETHOSTBYNAME_IS_THREAD_SAFE) && \
>      defined(HAVE_GETHOSTBYNAME_R) && !defined(BEOS)
>  #ifdef GETHOSTBYNAME_R_HOSTENT_DATA

Committed and retagged, thanks.  I just finished flushing out the last of
the tag updates that needed to happen as of this evening.  Can you please
grab a fresh copy of the 2_0_23 tag and make sure everything's still
kosher?

Thanks,
Cliff


--------------------------------------------------------------
   Cliff Woolley
   cliffwoolley@yahoo.com
   Charlottesville, VA