You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by ho...@apache.org on 2002/04/08 03:17:07 UTC
cvs commit: jakarta-ant/src/main/org/apache/tools/ant/taskdefs Available.java
holtdl 02/04/07 18:17:07
Modified: src/main/org/apache/tools/ant/taskdefs Available.java
Log:
overide -> override; writer -> file; fix line-breaks/spacing so
the output's a bit neater.
Revision Changes Path
1.37 +1 -4 jakarta-ant/src/main/org/apache/tools/ant/taskdefs/Available.java
Index: Available.java
===================================================================
RCS file: /home/cvs/jakarta-ant/src/main/org/apache/tools/ant/taskdefs/Available.java,v
retrieving revision 1.36
retrieving revision 1.37
diff -u -r1.36 -r1.37
--- Available.java 19 Mar 2002 22:45:06 -0000 1.36
+++ Available.java 8 Apr 2002 01:17:07 -0000 1.37
@@ -166,10 +166,7 @@
if (eval()) {
String lSep = System.getProperty("line.separator");
if (null != project.getProperty(property)) {
- log("DEPRECATED - <available> used to overide an existing property. "
- + lSep
- + " Build writer should not reuse the same property name for "
- + lSep + "different values.");
+ log("DEPRECATED - <available> used to override an existing property." + lSep + " Build file should not reuse the same property name for different values.");
}
this.project.setProperty(property, value);
}
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
RE: cvs commit: jakarta-ant/src/main/org/apache/tools/ant/taskdefs Available.java
Posted by Diane Holt <ho...@yahoo.com>.
--- Conor MacNeill <co...@cortexebusiness.com.au> wrote:
> Thanks.
No problem.
> It is true that most of Ant does not conform well to the coding
> conventions, especially the line length. We're slowly fixing it up
> but there is a long way to go.
I'm all for it -- I hate over-run lines. But since it's so prevalent in
Ant source, I actually thought it was the preferred way :) Glad to hear
it's not -- I'll fix it from now on whenever I run into it.
Diane
=====
(holtdl@yahoo.com)
__________________________________________________
Do You Yahoo!?
Yahoo! Tax Center - online filing with TurboTax
http://taxes.yahoo.com/
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
RE: cvs commit: jakarta-ant/src/main/org/apache/tools/ant/taskdefs Available.java
Posted by Conor MacNeill <co...@cortexebusiness.com.au>.
> From: Diane Holt [mailto:holtdl@yahoo.com]
>
> I'll fix it. (FTR, though, the original way it was exceeded that limit as
> well.)
>
Thanks.
It is true that most of Ant does not conform well to the coding conventions,
especially the line length. We're slowly fixing it up but there is a long
way to go.
Conor
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
RE: cvs commit: jakarta-ant/src/main/org/apache/tools/ant/taskdefs Available.java
Posted by Diane Holt <ho...@yahoo.com>.
> --- Conor MacNeill <co...@cortexebusiness.com.au> wrote:
> > Diane,
> >
> > One of the points in the Sun coding standard for Java is to limit line
> > lengths (to 80 characters).
>
> Where do I exceed that?
Okay, I read that one too fast, and thought (for some odd reason) you
meant that the output shouldn't exceed... (long day).
I'll fix it. (FTR, though, the original way it was exceeded that limit as
well.)
Diane
=====
(holtdl@yahoo.com)
__________________________________________________
Do You Yahoo!?
Yahoo! Tax Center - online filing with TurboTax
http://taxes.yahoo.com/
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
RE: cvs commit: jakarta-ant/src/main/org/apache/tools/ant/taskdefs Available.java
Posted by Diane Holt <ho...@yahoo.com>.
--- Conor MacNeill <co...@cortexebusiness.com.au> wrote:
> Diane,
>
> One of the points in the Sun coding standard for Java is to limit line
> lengths (to 80 characters).
Where do I exceed that?
Diane
=====
(holtdl@yahoo.com)
__________________________________________________
Do You Yahoo!?
Yahoo! Tax Center - online filing with TurboTax
http://taxes.yahoo.com/
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
RE: cvs commit: jakarta-ant/src/main/org/apache/tools/ant/taskdefs Available.java
Posted by Conor MacNeill <co...@cortexebusiness.com.au>.
Diane,
One of the points in the Sun coding standard for Java is to limit line
lengths (to 80 characters).
Conor
> -----Original Message-----
> From: holtdl@apache.org [mailto:holtdl@apache.org]
> Sent: Monday, 8 April 2002 11:17 AM
> To: jakarta-ant-cvs@apache.org
> Subject: cvs commit: jakarta-ant/src/main/org/apache/tools/ant/taskdefs
> Available.java
>
>
> holtdl 02/04/07 18:17:07
>
> Modified: src/main/org/apache/tools/ant/taskdefs Available.java
> Log:
> overide -> override; writer -> file; fix line-breaks/spacing so
> the output's a bit neater.
>
> Revision Changes Path
> 1.37 +1 -4
> jakarta-ant/src/main/org/apache/tools/ant/taskdefs/Available.java
>
> Index: Available.java
> ===================================================================
> RCS file:
> /home/cvs/jakarta-ant/src/main/org/apache/tools/ant/taskdefs/Avail
> able.java,v
> retrieving revision 1.36
> retrieving revision 1.37
> diff -u -r1.36 -r1.37
> --- Available.java 19 Mar 2002 22:45:06 -0000 1.36
> +++ Available.java 8 Apr 2002 01:17:07 -0000 1.37
> @@ -166,10 +166,7 @@
> if (eval()) {
> String lSep = System.getProperty("line.separator");
> if (null != project.getProperty(property)) {
> - log("DEPRECATED - <available> used to overide
> an existing property. "
> - + lSep
> - + " Build writer should not reuse the same
> property name for "
> - + lSep + "different values.");
> + log("DEPRECATED - <available> used to override
> an existing property." + lSep + " Build file should not reuse
> the same property name for different values.");
> }
> this.project.setProperty(property, value);
> }
>
>
>
>
> --
> To unsubscribe, e-mail: <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
>
>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>