You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/03/18 09:36:20 UTC
[GitHub] [pulsar-client-go] wolfstudy opened a new pull request #199: [Bug
fix] Fix seek by time error
wolfstudy opened a new pull request #199: [Bug fix] Fix seek by time error
URL: https://github.com/apache/pulsar-client-go/pull/199
Signed-off-by: xiaolong.ran <rx...@apache.org>
Fixes #194
### Modifications
- Fix seek by time
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar-client-go] wolfstudy commented on issue #199: [Bug fix] Fix
seek by time error
Posted by GitBox <gi...@apache.org>.
wolfstudy commented on issue #199: [Bug fix] Fix seek by time error
URL: https://github.com/apache/pulsar-client-go/pull/199#issuecomment-600967304
@cckellogg PTAL thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar-client-go] mileschao commented on issue #199: [Bug fix] Fix
seek by time error
Posted by GitBox <gi...@apache.org>.
mileschao commented on issue #199: [Bug fix] Fix seek by time error
URL: https://github.com/apache/pulsar-client-go/pull/199#issuecomment-600932127
@merlimat @sijie PR merge wanted. Thx :-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar-client-go] wolfstudy commented on a change in pull request
#199: [Bug fix] Fix seek by time error
Posted by GitBox <gi...@apache.org>.
wolfstudy commented on a change in pull request #199: [Bug fix] Fix seek by time error
URL: https://github.com/apache/pulsar-client-go/pull/199#discussion_r394769479
##########
File path: pulsar/consumer_partition.go
##########
@@ -323,7 +323,7 @@ func (pc *partitionConsumer) internalSeekByTime(seek *seekByTimeRequest) {
cmdSeek := &pb.CommandSeek{
ConsumerId: proto.Uint64(pc.consumerID),
RequestId: proto.Uint64(requestID),
- MessagePublishTime: proto.Uint64(uint64(seek.publishTime.Unix())),
+ MessagePublishTime: proto.Uint64(uint64(seek.publishTime.UnixNano() / 1e6)),
Review comment:
Thanks @cckellogg will fix it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar-client-go] wolfstudy merged pull request #199: [Bug fix]
Fix seek by time error
Posted by GitBox <gi...@apache.org>.
wolfstudy merged pull request #199: [Bug fix] Fix seek by time error
URL: https://github.com/apache/pulsar-client-go/pull/199
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar-client-go] cckellogg commented on a change in pull request
#199: [Bug fix] Fix seek by time error
Posted by GitBox <gi...@apache.org>.
cckellogg commented on a change in pull request #199: [Bug fix] Fix seek by time error
URL: https://github.com/apache/pulsar-client-go/pull/199#discussion_r394761553
##########
File path: pulsar/consumer_partition.go
##########
@@ -323,7 +323,7 @@ func (pc *partitionConsumer) internalSeekByTime(seek *seekByTimeRequest) {
cmdSeek := &pb.CommandSeek{
ConsumerId: proto.Uint64(pc.consumerID),
RequestId: proto.Uint64(requestID),
- MessagePublishTime: proto.Uint64(uint64(seek.publishTime.Unix())),
+ MessagePublishTime: proto.Uint64(uint64(seek.publishTime.UnixNano() / 1e6)),
Review comment:
Should we use a constant? `seek.publishTime.UnixNano() / int64(time.Millisecond)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services