You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2022/01/13 07:57:34 UTC

[GitHub] [servicecomb-service-center] little-cui commented on a change in pull request #1220: [feat] add engine info to instance

little-cui commented on a change in pull request #1220:
URL: https://github.com/apache/servicecomb-service-center/pull/1220#discussion_r783709225



##########
File path: server/service/disco/instance.go
##########
@@ -39,6 +39,8 @@ import (
 const (
 	defaultMinInterval = 5 * time.Second
 	defaultMinTimes    = 3
+	engineID           = "engineID"
+	engineName         = "engineName"

Review comment:
       注册逻辑不应该感知具体的properties，应该将配置中的properties下全量内容append到实例信息中




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org