You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/01/11 18:26:30 UTC

[GitHub] [arrow] jvictorhuguenin commented on a change in pull request #10425: ARROW-12910: [Gandiva][C++]Add support for ADD and SUBTRACT functions receiving time intervals

jvictorhuguenin commented on a change in pull request #10425:
URL: https://github.com/apache/arrow/pull/10425#discussion_r782420476



##########
File path: cpp/src/gandiva/precompiled/types.h
##########
@@ -571,4 +572,37 @@ gdv_month_interval castNULLABLEINTERVALYEAR_int32(int64_t context, gdv_int32 in)
 
 gdv_month_interval castNULLABLEINTERVALYEAR_int64(int64_t context, gdv_int64 in);
 
+gdv_int64 extractMillis_daytimeinterval(gdv_day_time_interval in);

Review comment:
       Because they need to be in types.h so I can use them intimestamp_arithmetic.cc, otherwise It would result in a link error




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org