You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/01 10:43:48 UTC
[GitHub] [spark] senthh opened a new pull request #35697: [SPARK-38213][CORE] Adding KafkaSink Metrics feature
senthh opened a new pull request #35697:
URL: https://github.com/apache/spark/pull/35697
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
KafkaSink Metrics feature is added
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
KafkaSink Metrics feature will be useful to collect and store the Spark application's metrics into Kafka topic.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
1. Created test case
2. also tested manually in local cluster too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] senthh edited a comment on pull request #35697: [SPARK-38213][CORE] Adding KafkaSink Metrics feature
Posted by GitBox <gi...@apache.org>.
senthh edited a comment on pull request #35697:
URL: https://github.com/apache/spark/pull/35697#issuecomment-1056162668
@dongjoon-hyun @HyukjinKwon @cloud-fan Could you pls review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] senthh commented on pull request #35697: [WIP][SPARK-38213][CORE] Adding KafkaSink Metrics feature
Posted by GitBox <gi...@apache.org>.
senthh commented on pull request #35697:
URL: https://github.com/apache/spark/pull/35697#issuecomment-1062841534
Creating new PR so I m closing this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] senthh closed pull request #35697: [SPARK-38213][CORE] Adding KafkaSink Metrics feature
Posted by GitBox <gi...@apache.org>.
senthh closed pull request #35697:
URL: https://github.com/apache/spark/pull/35697
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] senthh commented on pull request #35697: [SPARK-38213][CORE] Adding KafkaSink Metrics feature
Posted by GitBox <gi...@apache.org>.
senthh commented on pull request #35697:
URL: https://github.com/apache/spark/pull/35697#issuecomment-1056162668
@dongjoon-hyun @HyukjinKwon @cloud-fan Could you pls review this MR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #35697: [SPARK-38213][CORE] Adding KafkaSink Metrics feature
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #35697:
URL: https://github.com/apache/spark/pull/35697#issuecomment-1056118359
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #35697: [SPARK-38213][CORE] Adding KafkaSink Metrics feature
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #35697:
URL: https://github.com/apache/spark/pull/35697#discussion_r817336094
##########
File path: dev/deps/spark-deps-hadoop-2-hive-2.3
##########
@@ -161,6 +161,7 @@ jsp-api/2.1//jsp-api-2.1.jar
jsr305/3.0.0//jsr305-3.0.0.jar
jta/1.1//jta-1.1.jar
jul-to-slf4j/1.7.32//jul-to-slf4j-1.7.32.jar
+kafka-clients/3.1.0//kafka-clients-3.1.0.jar
Review comment:
This is the evidence of the breaking dependency change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] senthh commented on a change in pull request #35697: [SPARK-38213][CORE] Adding KafkaSink Metrics feature
Posted by GitBox <gi...@apache.org>.
senthh commented on a change in pull request #35697:
URL: https://github.com/apache/spark/pull/35697#discussion_r817339942
##########
File path: core/pom.xml
##########
@@ -501,7 +501,11 @@
<groupId>org.apache.commons</groupId>
<artifactId>commons-crypto</artifactId>
</dependency>
-
+ <dependency>
+ <groupId>org.apache.kafka</groupId>
+ <artifactId>kafka-clients</artifactId>
+ <version>${kafka.version}</version>
+ </dependency>
Review comment:
@dongjoon-hyun Thanks for pointing this. Moving this KafkaSink metrics features into external module will be correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #35697: [SPARK-38213][CORE] Adding KafkaSink Metrics feature
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #35697:
URL: https://github.com/apache/spark/pull/35697#discussion_r817335821
##########
File path: core/pom.xml
##########
@@ -501,7 +501,11 @@
<groupId>org.apache.commons</groupId>
<artifactId>commons-crypto</artifactId>
</dependency>
-
+ <dependency>
+ <groupId>org.apache.kafka</groupId>
+ <artifactId>kafka-clients</artifactId>
+ <version>${kafka.version}</version>
+ </dependency>
Review comment:
Thank you for pinging me, but Apache Spark module architecture doesn't allow this, @senthh .
Please note that Kafka modules are `external`.
https://github.com/apache/spark/blob/f14f6d6dea6c1a8099604596b623f4a191feaa5c/pom.xml#L104-L107
Please try a different way by respecting the existing module architecture.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org