[Fwd: Re: [orchestra] ConnectionManagerDataSource.isWrapperFor]

[simon <sk...@apache.org>]

-------- Forwarded Message --------
From: simon <si...@chello.at>
To: MyFaces Development <de...@myfaces.apache.org>
Subject: Re: [orchestra] ConnectionManagerDataSource.isWrapperFor
Date: Sat, 18 Aug 2007 14:08:24 +0200

On Sat, 2007-08-18 at 13:55 +0200, Mario Ivankovits wrote:
> Hi!
> > In ConnectionManagerDataSource, method isWrapperFor currently returns
> > false. Perhaps it should throw UnsupportedOperationException instead?
> And what about a solution using reflection?
> Maybe the most correct solution could be:

Yes, I agree that using reflection is the 100% correct solution. However
it's also the most complicated. When we discussed this earlier, I think
we agreed we didn't really need to do this.


> What do you think?
> If you don't like it, simply change the "return false" to the Exception
> you proposed.

I'll let you decide what's best on this. 

Cheers,

Simon

Re: [Fwd: Re: [orchestra] ConnectionManagerDataSource.isWrapperFor]

[Mario Ivankovits <ma...@ops.co.at>]

Hi!
>> Hi!
>>     
>>> In ConnectionManagerDataSource, method isWrapperFor currently returns
>>> false. Perhaps it should throw UnsupportedOperationException instead?
>>>       
>> And what about a solution using reflection?
>> Maybe the most correct solution could be:
>>     
>
> Yes, I agree that using reflection is the 100% correct solution. However
> it's also the most complicated. When we discussed this earlier, I think
> we agreed we didn't really need to do this.
>   
Yes, you are right. I've committed the throw UOE now with the reflection
code in comment - just in case we need it later.

Ciao,
Mario