You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@calcite.apache.org by "Julian Hyde (JIRA)" <ji...@apache.org> on 2014/06/21 00:08:24 UTC
[jira] [Updated] (OPTIQ-306) Standardize code style for "import
package.*;"
[ https://issues.apache.org/jira/browse/OPTIQ-306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julian Hyde updated OPTIQ-306:
------------------------------
Assignee: (was: Julian Hyde)
> Standardize code style for "import package.*;"
> ----------------------------------------------
>
> Key: OPTIQ-306
> URL: https://issues.apache.org/jira/browse/OPTIQ-306
> Project: optiq
> Issue Type: Improvement
> Reporter: Julian Hyde
> Priority: Trivial
>
> Our house style does not specify whether/when imports are to be converted to stars. I propose that imports should be converted to stars if there are more than 3 from the same package. Thus:
> {code}
> import a.b.C1;
> import a.b.C2;
> import a.b.C3;
> {code}
> becomes
> {code}
> import a.b.*;
> {code}
> when {{a.b.C4}} is added. This is consistent with IntelliJ's default rule.
> It is OK to use stars if there are 3 or fewer uses. Thus removing the use of {{a.b.C2}} would not require imports to be changed.
> Checkstyle has a rule to ban star imports (excluding certain packages) but does not allow them to be limited to a particular number.
--
This message was sent by Atlassian JIRA
(v6.2#6252)